[7.0] Add reindex feature to Upgrade Assistant (#27457) #29516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixup saved objects * WIP reindex state machine * WIP UI * Separate status from current step * Add error messages * Copy types to CallWithInternalUser * Use backend worker * Add progress bar for large indices * Cleanup worker implementation * Add tests for ReindexService * Fix types * Fix CI * Add support for mapping coerced boolean fields * Add basic functional integration test * Cleanup reindexing backend, add more checks * Cleanup frontend code and add tests * Support removal of _default_ mapping + add tests * Add reindex warnings to reindex service * Add confirmation modal for reindex warnings * Cleanup flyout appearance * Generate new index name intelligently * Design tweaks * Show reindex button in both grouping modes * Add data archive integration tests * Change flyout design to two step process * Reorganize flyout files * Use custom steps component * Allow writes to indices if anything fails * Misc cleanup * Design edits * Only show warnings panel when reindex has not begun * Fix types * Handle moving existing aliases * Move integration tests to separate config * Fix ReindexButton bugs when changing pages * Fix polling service tests * Refactor ReindexService and ML handling (backend only) * Add credential caching and paused state to backend * Add paused state to frontend * Fix ts errors * Update copy * Add check for node version before ML step * Update data archive format * Update snapshots for React upgrade * Handle _default_ mappings correctly in warning checks * Use hashed state of reindex operation for credential storage * Address tyler's comments * Add watcher stop/starting * Use json-stable-stringify and sha256 for CredentialStore * Add types for json-stable-stringify
|
Pinging @elastic/kibana-operations |
💔 Build Failed |
💔 Build Failed |
joshdover
force-pushed
the
forwardport/pr-27457
branch
from
ed87d86 to
d2f9b8e
Compare
💚 Build Succeeded |
|
I know we were pinged as code owners, but the changes to our stuff is minimal and looks fine. Let me know if you want an actual review from us! |
tylersmalley
approved these changes
Jan 29, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward ports #27457 to master branch.
TODO
_xpackprefix from Elasticsearch API callsChange mapping type to(turns out this just works if using the typeless API)_docfor new indices