Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate ML missed labels #29256

Merged
merged 107 commits into from
Jan 29, 2019

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Jan 24, 2019

Translate /ml/public/jobs/jobs_list/components/multi_job_actions/group_selector folder
and next files:

  • ml/public/timeseriesexplorer/timeseriesexplorer.html
  • ml/public/settings/settings.js
  • ml/public/settings/breadcrumbs.js
  • ml/public/components/anomalies_table/anomaly_details.js
  • ml/public/jobs/components/job_timepicker_modal/job_timepicker_modal.html
  • ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js
  • ml/public/jobs/jobs_list/components/job_details/datafeed_preview_tab.js
  • ml/public/jobs/new_job/simple/components/general_job_details/general_job_details.html
  • ml/public/jobs/new_job/simple/components/bucket_span_estimator/bucket_span_estimator_directive.js
  • ml/public/jobs/new_job/simple/components/fields_selection_population/fields_selection.html

Issue: #25454

Guidline
Readme

@elasticmachine
Copy link
Contributor

💔 Build Failed

@pavel06081991
Copy link
Contributor

pavel06081991 commented Jan 24, 2019

And please fix unit tests

@Nox911 Nox911 requested a review from peteharverson January 25, 2019 08:39
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Jan 29, 2019

retest

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit fc1d146 into elastic:master Jan 29, 2019
@Nox911 Nox911 deleted the feature/ml-translate-missing-labels branch January 29, 2019 14:09
@Nox911
Copy link
Contributor Author

Nox911 commented Jan 29, 2019

6.x/6.7.0: 398d095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants