-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Remove dashboards #29043
[APM] Remove dashboards #29043
Conversation
related to elastic#1673
💔 Build Failed |
@simitt You can probably safely delete this test now kibana/test/functional/apps/home/_add_data.js Lines 37 to 55 in 78107bb
|
@sqren the index-pattern is still loaded. Is there a way to change the test to load the index pattern? |
The current test doesn't do any expectations for index pattern as far as I can see? I agree it would be a good idea to add one, but this doesn't reduce test coverage afaict |
Testing for the index pattern should probably be done by calling the saved objects API, verifying that it is there. |
Thanks, I removed the test. |
💚 Build Succeeded |
💚 Build Succeeded |
they are no longer bundled with kibana as of elastic/kibana#29043
* remove tests for dashboards they are no longer bundled with kibana as of elastic/kibana#29043 * update generated index pattern location
From 7.0 on APM dashboards and visualisations will no longer be bundled directly with Kibana or APM Server.
related to elastic/apm-server#1673