Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove dashboards #29043

Merged
merged 2 commits into from
Jan 21, 2019
Merged

[APM] Remove dashboards #29043

merged 2 commits into from
Jan 21, 2019

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jan 21, 2019

From 7.0 on APM dashboards and visualisations will no longer be bundled directly with Kibana or APM Server.

related to elastic/apm-server#1673

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
Copy link
Member

sorenlouv commented Jan 21, 2019

@simitt You can probably safely delete this test now

describe('apm', function describeIndexTests() {
it('should install saved objects', async ()=> {
await PageObjects.common.navigateToUrl('home', 'tutorial_directory');
await PageObjects.header.waitUntilLoadingHasFinished();
await retry.try(async () => {
await PageObjects.home.clickSynopsis('apm');
});
await PageObjects.home.loadSavedObjects();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.searchForDashboardWithName('APM');
const countOfDashboards = await PageObjects.dashboard.getCountOfDashboardsInListingTable();
expect(countOfDashboards).to.equal(5);
});
});

@simitt
Copy link
Contributor Author

simitt commented Jan 21, 2019

@sqren the index-pattern is still loaded. Is there a way to change the test to load the index pattern?

@sorenlouv
Copy link
Member

the index-pattern is still loaded. Is there a way to change the test to load the index pattern?

The current test doesn't do any expectations for index pattern as far as I can see? I agree it would be a good idea to add one, but this doesn't reduce test coverage afaict

@sorenlouv
Copy link
Member

Testing for the index pattern should probably be done by calling the saved objects API, verifying that it is there.

@simitt
Copy link
Contributor Author

simitt commented Jan 21, 2019

Thanks, I removed the test.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simitt simitt merged commit 414dec3 into elastic:master Jan 21, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

graphaelli added a commit to graphaelli/apm-server that referenced this pull request Jan 26, 2019
they are no longer bundled with kibana as of elastic/kibana#29043
graphaelli added a commit to elastic/apm-server that referenced this pull request Jan 27, 2019
* remove tests for dashboards

they are no longer bundled with kibana as of elastic/kibana#29043

* update generated index pattern location
@simitt simitt deleted the apm-remove-dashboards branch February 12, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants