-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use references attribute for saved objects of type search #28602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-platform |
mikecote
changed the title
Add search references
Use references attribute for saved objects of type search
Jan 11, 2019
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-search-references
branch
2 times, most recently
from
January 11, 2019 19:50
85992a4
to
d2c4630
Compare
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
add-search-references
branch
from
January 11, 2019 21:02
d2c4630
to
4953764
Compare
💚 Build Succeeded |
mikecote
force-pushed
the
add-search-references
branch
from
January 22, 2019 15:08
4953764
to
739f33d
Compare
💚 Build Succeeded |
Dependent pull request will migrate all types to use references, PR no longer needed. |
mikecote
added
the
non-issue
Indicates to automation that a pull request should not appear in the release notes
label
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements "references" to saved object type "search". Issue details can be found here #27210.
PR is blocked until #28199 is merged. This PR is based off that PR's branch.
Checklist
- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers