Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use references attribute for saved objects of type search #28602

Closed
wants to merge 22 commits into from

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Jan 11, 2019

Summary

Implements "references" to saved object type "search". Issue details can be found here #27210.

PR is blocked until #28199 is merged. This PR is based off that PR's branch.

Checklist

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@mikecote mikecote added blocked WIP Work in progress Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 labels Jan 11, 2019
@mikecote mikecote self-assigned this Jan 11, 2019
@mikecote mikecote requested a review from a team as a code owner January 11, 2019 18:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@mikecote mikecote changed the title Add search references Use references attribute for saved objects of type search Jan 11, 2019
@elasticmachine

This comment has been minimized.

@mikecote mikecote force-pushed the add-search-references branch 2 times, most recently from 85992a4 to d2c4630 Compare January 11, 2019 19:50
@elasticmachine

This comment has been minimized.

@mikecote mikecote force-pushed the add-search-references branch from d2c4630 to 4953764 Compare January 11, 2019 21:02
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote force-pushed the add-search-references branch from 4953764 to 739f33d Compare January 22, 2019 15:08
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote closed this Jan 22, 2019
@mikecote
Copy link
Contributor Author

Dependent pull request will migrate all types to use references, PR no longer needed.

@mikecote mikecote added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked non-issue Indicates to automation that a pull request should not appear in the release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants