Add hintboxes in sidebar for additional information #2860
Merged
+47
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidkpc
added a commit
that referenced
this pull request
Feb 5, 2015
Add hintboxes in sidebar for additional information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests moves additional information or warning texts to collapsable hintboxes in the sidebar.
The original pull request and discussion can be found here: #2836
The screenshots show the new hint boxes, which will hide and show when clicking the icons.
I also tried yellow backgroundd for warning boxes: looked terrible.
Do you think putting the .raw tip in the same box is fine. The disadvantage is, if you don't expand it you won't see the tip. Possibilities could be: using two icons again (like in the screens above) - though I still would make them both expand the same box (since the tip box without the warning box is kind of contextless). An other option would be to indicate the tip in another way.
In my opinion it is also fine, without additional hinting, but what do you think?