-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap defaultAppId with defaultRoute in example config #28547
Swap defaultAppId with defaultRoute in example config #28547
Conversation
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also deprecate the old defaultAppId
option. What do you think @tylersmalley ?
Does |
@matschaffer I believe it is working. At least I just set into the And it worked. Let's see if @tylersmalley has any insights on this. |
Now that we have Kibana Spaces, it would be great that "defaultRoute" is available as advanced setting! |
BTW, for this PR, it could be interesting to fix documentation for "kibana.defaultAppId" default value. |
Compared to defaultAppId, I see a major limitation in defaultRoute:
Personally, I use |
Yeah this is a little confusing, but +1 on the swap to de-emphasize kibana the application. Taking a step back, we have the kibana platform which has applications. Inside that there's a SPA called kibana which includes discover, visualize, dashboard, home, dev tools). kibana.defaultAppId sets the page that you'll be redirected to if you visit localhost:5601/app/kibana using the browser router server.defaultRoute sets the page that you'll be redirected to if you visit localhost:5601/ using the server router I think deprecating defaultAppId isn't going to be very straight forward because the triggers are separate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, #28547 (comment) would be cool too. Spaces integration sounds interesting but I'm not 100% familiar with it yet
I realized today that for a "home page per Kibana Space", there is already an issue for that : |
I'm removing my review on this since @jbudz already reviewed it. I'm not sure what the plan is here since it has been idle since January. |
💔 Build Failed |
34d1e9b
to
02452c0
Compare
Rebased to try to clear CI failures. Diff looks unchanged. @jbudz - let me know if I'm clear to click squash merge or if something else should happen first (after CI passes, of course). |
💚 Build Succeeded |
👍 go for it |
Connected to #6902
Summary
Swaps example config based on current actual functionality. I got
confused about which setting to use after using the example config as a
starting point.
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers