[i18n] Translate ML - components - rule editor #28262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
💚 Build Succeeded |
peteharverson
requested changes
Jan 14, 2019
There was a problem hiding this comment.
A few changes to the IDs should be made here, plus an import statement can be removed I think once changes from #27802 are merged in.
x-pack/plugins/ml/public/components/anomalies_table/anomalies_table_directive.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/condition_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/condition_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/condition_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/condition_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/scope_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/scope_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/scope_expression.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/scope_section.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/rule_editor/scope_section.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
peteharverson
approved these changes
Jan 16, 2019
💔 Build Failed |
|
retest |
💚 Build Succeeded |
Nox911
added a commit
to Nox911/kibana
that referenced
this pull request
Jan 17, 2019
* Translate rule editor * Fix 'then' -> 'than' * Update snapshots * Fix rule description * Resolve issues from review comments * Remove extra space * Update snapshots * Resolve review comments * Update snapshots
Nox911
added a commit
that referenced
this pull request
Jan 17, 2019
|
6.x/6.7.0: d9a92ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate ml -> public -> components -> rule_editor
Issue: #25454
Guidline
Readme