[i18n] Translate ML - items grid and item select #28236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
|
Pinging @elastic/ml-ui |
💔 Build Failed |
pavel06081991
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
@peteharverson code LGTM but could not open tabs on UI to check that nothing is broken.
Also @peteharverson we could not find where mlItemSelect directive is used(it looks like nowhere)
peteharverson
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Tested and LGTM.
@pavel06081991 you're right /ml/public/components/item_select is not used any more. Once this is merged I will delete it in another PR to keep the work separate from the localization changes.
💚 Build Succeeded |
pavel06081991
pushed a commit
to pavel06081991/kibana
that referenced
this pull request
Jan 9, 2019
* Translate item_select * Translate items_grid
Nox911
pushed a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate ml -> public -> components -> items_grid
Translate ml -> public -> components -> item_select
Issue: #25454
Guidline
Readme