Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update REST endpoint calls to remove _xpack #28069

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jan 4, 2019

Summary

As a result of elastic/elasticsearch#35958 which deprecates the X-Pack-centric REST endpoints, switches the start of the endpoint calls to use e.g. _ml rather than _xpack/ml , preventing deprecation warnings being generated in Elasticsearch.

Also updates the corresponding unit test to check that the URLs start with a leading forward slash, rather than /_xpack/, to test against all the plugin endpoints being called ('/_ml' and '/_security').

Checklist

(https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Fixes #26876

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson peteharverson merged commit ef5e7a5 into elastic:master Jan 4, 2019
@peteharverson peteharverson deleted the ml-endpoint-prefix branch January 4, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants