Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate ML - server - lib #27974

Merged
merged 70 commits into from
Jan 8, 2019

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Jan 3, 2019

Translate ml -> server -> lib

Issue: #25454

Guidline
Readme

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@Nox911 Nox911 changed the title [i18n] Translate ML - server -lib [i18n] Translate ML - server - lib Jan 3, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally, works good

@peteharverson peteharverson requested review from jgowdyelastic and removed request for peteharverson January 4, 2019 10:09
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel06081991 pavel06081991 merged commit 2dfe413 into elastic:master Jan 8, 2019
@pavel06081991 pavel06081991 deleted the feature/translate-server-lib branch January 8, 2019 08:13
pavel06081991 pushed a commit to pavel06081991/kibana that referenced this pull request Jan 8, 2019
Nox911 pushed a commit that referenced this pull request Jan 8, 2019
@Nox911 Nox911 added backported and removed review labels Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants