Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Localize ml components ( part 2 - job picker ) #27958

Closed
wants to merge 2 commits into from

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jan 3, 2019

[ML] translate the following components

  • job_select_list

Parent Issue #25454

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

<div style="flex:0 0 auto;">
<div popover-placement="bottom"
popover-placement="bottom"
popover-html-unsafe="{{unsafeHtml}}"
popover-append-to-body="false"
popover-trigger="click"
class="ml-job-select-btn"
tooltip="{{description.txt}} selected"
aria-label="Job selection menu"
tooltip="{{ ::'xpack.ml.jobSelectList.menuButtonTooltip' | i18n: { defaultMessage: '{descriptionText} selected', values: {descriptionText: description.txt} } }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason descriptionText: description.txt is not binding to the UI (returns empty string).

Copy link
Contributor

@pavel06081991 pavel06081991 Jan 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that is because you use one time binding operator ::. When you pass some variable to values then you must not use one time binding

@peteharverson peteharverson changed the title Localize ml components ( part 2 ) [ML] Localize ml components ( part 2 ) Jan 3, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@peteharverson peteharverson changed the title [ML] Localize ml components ( part 2 ) [ML] Localize ml components ( part 2 - job picker ) Jan 3, 2019
@pavel06081991
Copy link
Contributor

pavel06081991 commented Jan 11, 2019

duplicate of #27803

@Bamieh Bamieh deleted the localize-ml-components-2 branch February 15, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants