[ML] Localize ml components ( part 1 ) #27957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
💔 Build Failed |
💚 Build Succeeded |
x-pack/plugins/ml/public/components/job_group_select/job_group_select.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/job_group_select/job_group_select.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
peteharverson
requested review from
jgowdyelastic
and removed request for
peteharverson
💚 Build Succeeded |
peteharverson
pushed a commit
to peteharverson/kibana
that referenced
this pull request
Jan 16, 2019
* feature(ml): localize components * fix xpack.i18n localization strings * Resolve review comments * Add I18nProvider * Fix adding label to angular scope * Fix case of word * Update test snapshots. * Resolve review comments
peteharverson
added a commit
that referenced
this pull request
Jan 16, 2019
|
6.x/6.7.0: 6e1ac42 |
| ariaLabel = intl.formatMessage({ | ||
| id: 'xpack.ml.fieldTypeIcon.geoPointTypeAriaLabel', | ||
| defaultMessage: '{geoPointParam} type' | ||
| }, { geoPointParam: 'geo_point' }); |
There was a problem hiding this comment.
@Bamieh, hello, could you please confirm that "geo point" string should not be translated? Otherwise, could you clarify why it is passed in as a parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ML] translate the following components
Parent Issue #25454