Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Translate ML - settings - calendar management #27839

Merged
merged 72 commits into from
Jan 3, 2019
Merged

[i18n] Translate ML - settings - calendar management #27839

merged 72 commits into from
Jan 3, 2019

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Dec 28, 2018

Translate ml -> public -> settings -> calendar_management

Issue: #25454

Guidline
Readme

Nox911 added 30 commits September 24, 2018 18:58
@Nox911
Merge pull request #1 from elastic/master
c7ec189 
update
@Nox911
Merge pull request #2 from elastic/master
fa01b88 
second merge
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
70f6c7e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
68587a0
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
42aa7d3
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
efeaefe
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8a054ed
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b0d1660
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
62b6ad1
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
acbad4b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
a850650
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
0a200ce
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b2a8244
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b4b979e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
d349a4f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ae285b9
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
3051641
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
6231971
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f86a3d4
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
cf813c7
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
1aba03f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
491009b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
e243126
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
e74bd61
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8bc5ffa
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
5787937
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f17fa1e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
c63b0a6
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ed62b5b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
df4fab4
@Nox911
Copy link
Contributor Author

Nox911 commented Jan 2, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Jan 2, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

pavel06081991
pavel06081991 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment. Checked locally, works good

x-pack/plugins/ml/public/settings/calendars/edit/new_calendar.js Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

@peteharverson peteharverson requested review from alvarezmelissa87 and removed request for peteharverson January 2, 2019 12:11
@pavel06081991
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Jan 2, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

alvarezmelissa87
alvarezmelissa87 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 6a45583 into elastic:master Jan 3, 2019
pavel06081991 pushed a commit to pavel06081991/kibana that referenced this pull request Jan 3, 2019
@Nox911 @pavel06081991
[i18n] Translate ML - settings - calendar management (elastic#27839)
73f28f4 
* Translate settings -> calendar management

* Update snapshots

* Update test for calendar form

* Minor fix for id name
@pavel06081991 pavel06081991 mentioned this pull request Jan 3, 2019
Merged
Nox911 pushed a commit that referenced this pull request Jan 3, 2019
@pavel06081991 @Nox911
[i18n] Translate ML - settings - calendar management (#27839) (#27953)
270485d 
* Translate settings -> calendar management

* Update snapshots

* Update test for calendar form

* Minor fix for id name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees
No one assigned
Labels
backported :ml Project:i18n v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nox911 @elasticmachine @pavel06081991 @alvarezmelissa87