Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] fix display of maps list (#27796) #27799

Merged
merged 1 commit into from
Dec 27, 2018
Merged

[6.x] fix display of maps list (#27796) #27799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...core_plugins/kibana/public/dashboard/listing/__snapshots__/dashboard_listing.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exports[`after fetch initialFilter 1`] = `
<EuiButton
color="primary"
data-test-subj="newDashboardLink"
fill={false}
fill={true}
href="#/dashboard"
iconSide="left"
type="button"
Expand Down Expand Up @@ -333,7 +333,7 @@ exports[`after fetch renders table rows 1`] = `
<EuiButton
color="primary"
data-test-subj="newDashboardLink"
fill={false}
fill={true}
href="#/dashboard"
iconSide="left"
type="button"
Expand Down Expand Up @@ -501,7 +501,7 @@ exports[`after fetch renders warning when listingLimit is exceeded 1`] = `
<EuiButton
color="primary"
data-test-subj="newDashboardLink"
fill={false}
fill={true}
href="#/dashboard"
iconSide="left"
type="button"
Expand Down
1 change: 1 addition & 0 deletions src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ class DashboardListingUi extends React.Component {
<EuiButton
href={`#${DashboardConstants.CREATE_NEW_DASHBOARD_URL}`}
data-test-subj="newDashboardLink"
fill
>
<FormattedMessage
id="kbn.dashboard.listing.createNewDashboardButtonLabel"
Expand Down
7 changes: 5 additions & 2 deletions x-pack/plugins/gis/public/_main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@


// Makes sure the listing page is full height with proper background
map-listing, .gisListingPage {
display: flex;
flex-grow: 1;
}


#gis-plugin {
Expand Down
5 changes: 3 additions & 2 deletions x-pack/plugins/gis/public/shared/components/map_listing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ export class MapListing extends React.Component {
<EuiButton
href={`#/map`}
data-test-subj="newMapLink"
fill
>
Create new map
</EuiButton>
Expand Down Expand Up @@ -372,8 +373,8 @@ export class MapListing extends React.Component {

render() {
return (
<EuiPage data-test-subj="gisListingPage" restrictWidth>
<EuiPageBody>
<EuiPage data-test-subj="gisListingPage" className="gisListingPage">
<EuiPageBody restrictWidth>
{this.renderPageContent()}
</EuiPageBody>
</EuiPage>
Expand Down