Backport [Canvas][Layout Engine] Persistent grouping #25854 #27459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Canvas element grouping (squashed) fix: don't allow a tilted group feat: allow rotation as long as it's a multiple of 90 degrees same as previous but recursively minor refactor - predicate minor refactor - removed if minor refactor - extracted groupedShape minor refactor - extracted out magic; temporarily only enable 0 degree orientations minor refactor - recurse minor refactor - ignore annotations minor refactor - simplify recursion minor refactor - simplify recursion 2 removed key gestures remove ancestors 1 remove ancestors 2 remove ancestors 3 remove ancestors 4 * lint * separate elements and groups in storage * renamed `element...` to `node...` (except exported names and action payload props, for now) * be able to remove a group * fixing group deletion * not re-persisting unnecessarily * persist / unpersist group right on the keyboard action * solving inverted cascading for backward compatibility * fix failing test case * page cloning with group trees of arbitrary depth * extracted out cloneSubgraphs * basic copy-paste that handles a grouping tree of arbitrary depth * fix: when legacy dataset doesn't have `groups`, it should avoid an `undefined` * PR feedback: regularize group IDs * lint: curlies * schemaVersion bump * copy/paste: restore selection and 10px offset of newly pasted element * - fix regression with ad hoc groups - fix copy/paste offsetting * PR feedback: don't persist node `type` and group `expression` * chore: remove commented out code * chore: switch Object.entries to Object.keys * fix: handle undefined value this might be caused by a race condition or something. this fix is probably just covering up some other bug :(
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25854 to 6.x