Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate ML - New Job - population #27388

Merged

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Dec 18, 2018

Translate ml -> public -> jobs -> new_job -> simple -> population

Issue: #25454

Guidline
Readme

@Nox911
Copy link
Contributor Author

Nox911 commented Dec 20, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@pavel06081991
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, works good. LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Jan 3, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit e5962a3 into elastic:master Jan 3, 2019
pavel06081991 pushed a commit to pavel06081991/kibana that referenced this pull request Jan 3, 2019
* Translate new_job population

* Separate id for documentCount chart and other charts

* Resolve part of comments

* Fix issues
Nox911 pushed a commit that referenced this pull request Jan 3, 2019
* Translate new_job population

* Separate id for documentCount chart and other charts

* Resolve part of comments

* Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants