Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCR] Accessibility fixes #27268

Merged
merged 3 commits into from
Dec 17, 2018
Merged

[CCR] Accessibility fixes #27268

merged 3 commits into from
Dec 17, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Dec 14, 2018 •
edited
Loading

  • Add "Actions" title to actions column in CCR table so that it's clear what that column contains
  • Convert table column headers from nodes to strings so that VoiceOver doesn't read them as "Object object"
  • Fix bug where CCR table cells aren't being read by screen reader (edit: looks like this is a bug with VoiceOver and Chrome)

@cjcenizal cjcenizal added Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 14, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

sebelga
sebelga approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjcenizal cjcenizal merged commit 2ccbb41 into elastic:feature/ccr Dec 17, 2018
@cjcenizal cjcenizal deleted the ccr/accessibility branch December 17, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@jen-huang jen-huang Awaiting requested review from jen-huang

Assignees
No one assigned
Labels
Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @elasticmachine @sebelga