Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] visualizations field formatting refactoring #26951

Closed
wants to merge 49 commits into from
Closed

[WIP] visualizations field formatting refactoring #26951

wants to merge 49 commits into from

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Dec 11, 2018 •
edited
Loading

Summary

handling field formatting in the expressions

  • all visualizations now get formatting options passed in as part of the configuration
  • vislib charts no longer require aggConfig information
  • legacy response handler now only does table splitting and doesn't require aggConfigs
  • point series response handler now builds directly on top of tabify table and doesn't require aggConfigs
  • hierarchical response handler now builds directly on top of tabify table and doesn't require aggConfigs

todo:

  • cleanup
  • tests

@ppisljar ppisljar added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 11, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes timroes mentioned this pull request Dec 12, 2018
Closed
58 tasks
@ppisljar ppisljar added WIP Work in progress v7.0.0 and removed discuss labels Dec 20, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar changed the title field formatting PoC [WIP] field formatting refactoring Dec 20, 2018
@ppisljar ppisljar changed the title [WIP] field formatting refactoring [WIP] visualizations field formatting refactoring Dec 20, 2018
lukeelmers
lukeelmers reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial cursory read of the code. Still need to look at changes to build_pipeline.ts and do some testing once the PR is ready.

src/legacy/core_plugins/metric_vis/public/metric_vis_controller.js Outdated Show resolved Hide resolved
src/ui/public/vis/vis_filters.js Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukeelmers lukeelmers mentioned this pull request Dec 21, 2018
Closed
3 tasks
@lukeelmers lukeelmers mentioned this pull request Jan 2, 2019
Merged
8 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar force-pushed the pipeline/fieldFormattingPoC branch 3 times, most recently from df69d3e to 1ea63c6 Compare January 7, 2019 12:34
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar
Copy link
Member Author

closing in favor of #28746

@ppisljar ppisljar closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers left review comments

@timroes timroes Awaiting requested review from timroes

@markov00 markov00 Awaiting requested review from markov00

Assignees
No one assigned
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppisljar @elasticmachine @lukeelmers