Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade resize-observer-polyfill version #26929

Closed
wants to merge 1 commit into from
Closed

upgrade resize-observer-polyfill version #26929

wants to merge 1 commit into from

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Dec 10, 2018

Summary

We are currently resolving the typescript type check error and some deps errors while trying to merge the code repo.

There is a couple of errors related with resize-observer-polyfill but not in code codebase. This change fixes these errors.

The version of resize-observer-polyfill in kibana root is not aligned with the one in x-pack folder.

@mw-ding mw-ding requested a review from spalger December 10, 2018 22:55
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding
Copy link
Contributor Author

mw-ding commented Dec 11, 2018

test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding
Copy link
Contributor Author

mw-ding commented Dec 11, 2018

test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding
Copy link
Contributor Author

mw-ding commented Dec 11, 2018

close this PR to move to a different branch in my local forked repository other than master

new PR here: #26990

@mw-ding mw-ding closed this Dec 11, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants