Typescript search embeddable #26863
Merged
Typescript search embeddable #26863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
cd0b9df to
8068d33
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
8068d33 to
e649458
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
e649458 to
adb0b9f
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
adb0b9f to
1c55fa4
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
1c55fa4 to
873b010
Compare
💚 Build Succeeded |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
873b010 to
762cb00
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
762cb00 to
54ac214
Compare
💚 Build Succeeded |
timroes
suggested changes
Dec 11, 2018
src/ui/public/timefilter/get_time.ts
Outdated
| */ | ||
|
|
||
| import dateMath from '@elastic/datemath'; | ||
| import _ from 'lodash'; |
There was a problem hiding this comment.
Since we're anyway touching this, let's make this a named import instead.
| onEmbeddableStateChanged: OnEmbeddableStateChanged; | ||
| savedSearch: SavedSearch; | ||
| editUrl: string; | ||
| loader: SavedSearchLoader; |
There was a problem hiding this comment.
This should be removed, since we don't pass the loader in. It currently only works, because search_embeddable_factory is still in JS.
| @@ -96,6 +160,9 @@ export class SearchEmbeddable extends Embeddable { | |||
|
|
|||
| const timeRangeSearchSource = this.searchScope.searchSource.create(); | |||
| timeRangeSearchSource.setField('filter', () => { | |||
| if (!this.searchScope || !this.timeRange) { | |||
There was a problem hiding this comment.
Maybe a better way to not need all those checks, would be just first creating that scope on a local variable, in this function and then assign at the end to the class:
const searchScope: SearchScope = this.$rootScope.$new();
searchScope.description = this.savedSearch.description;
// ...
searchScope.setSortOrder = (columnName, direction) => {
// no check now required
searchScope.sort = this.customization.sort = [ columnName, direction ];
}
// ...
this.searchScope = searchScope;There was a problem hiding this comment.
But since we're checking in a lot of places still for existence of columns not sure if it really adds too much to the readability. So feel free to treat this as you wish.
stacey-gammon
force-pushed
the
2018-12-09-typescript-search-embeddable
branch
from
f1b5707 to
6b5fe1d
Compare
💚 Build Succeeded |
|
done @timroes, thanks! |
ppisljar
reviewed
Dec 12, 2018
| @@ -36,7 +36,7 @@ declare const datemath: { | |||
| input: string, | |||
| options?: { | |||
| roundUp?: boolean; | |||
| forceNow?: boolean; | |||
| forceNow?: Date; | |||
There was a problem hiding this comment.
not familiar with this code, but could we rename parameter or add some jsdocs decribing what this forceNow does ?
ppisljar
approved these changes
Dec 12, 2018
💚 Build Succeeded |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Dec 12, 2018
* typescript search embeddable * Add a comment
stacey-gammon
added a commit
that referenced
this pull request
Dec 12, 2018
rayafratkina
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
rayafratkina
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.