Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing apm-server response error monitor #26787

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Dec 6, 2018

backports #26570 to 6.5. That is not merged yet because tests can't pass until a new elasticsearch snapshot including elastic/elasticsearch#36178 is available. That build has been failing for a few days for unrelated reasons. Since the elasticsearch backport of that, in elastic/elasticsearch#36273, is already in the latest 6.5 snapshot, this should pass tests.

before/after:
image

for elastic/apm-server#1614

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-monitoring

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@roncohen roncohen merged commit 57a468f into elastic:6.5 Dec 7, 2018
@roncohen
Copy link
Contributor

roncohen commented Dec 7, 2018

good work! @graphaelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants