[reporting] disable surprisingly failing test #26738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgriffith
approved these changes
Dec 5, 2018
💔 Build Failed |
|
The chromium tests failed because of the reason we're looking into
|
spalger
force-pushed
the
disable-surprisingly-failing-test
branch
from
b5c25c6 to
586f9e6
Compare
This comment has been minimized.
This comment has been minimized.
tsullivan
approved these changes
Dec 6, 2018
💚 Build Succeeded |
|
I was in the middle of a |
|
I'm working on adding more logging on the download route handler, to show the reason why the requested report failed:
Still needs investigation |
tsullivan
pushed a commit
to tsullivan/kibana
that referenced
this pull request
Dec 12, 2018
* [reporting] disable surprisingly failing test * fix expected completion count * quit chasing, just exclude these configs
tsullivan
added a commit
that referenced
this pull request
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests started failing on master seemingly out of nowhere, and they're tricky to debug so we are disabling them in master so that @tsullivan has time to debug and fix them.