[Telemetry] Remove initial delay to check and send #26575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar to #25897 |
💚 Build Succeeded |
pickypg
requested changes
Dec 3, 2018
|
Stats will get called and transmitted after 1 minute: |
💚 Build Succeeded |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 4, 2018
* [Telemetry] Remove initial delay to check and send * do not fire immediately
tsullivan
added a commit
that referenced
this pull request
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21241 (comment)
Summary
Before 6.3.0, Telemetry stats had to be explicitly opted-out of to prevent your cluster to send stats. In 6.3.0, the method was changed to opt-in. This means a user doesn't have to read a message about sharing their cluster stats with us and click "Opt out" before anything is sent to Elastic.
Because it was previously the case that the user would have to read and opt out, we had a 2-minute delay in the browser before creating and sending the payload.
This PR takes out the 2 minute delay. When a page loads, code on the page will check immediately if they are opted in, and will send control to the "send if due" logic that has Telemetry sent to Elastic from the browser up to once per day.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibility