Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BeatsCM] Cleanup and refactor #26425

Closed
wants to merge 53 commits into from
Closed

[BeatsCM] Cleanup and refactor #26425

wants to merge 53 commits into from

Conversation

mattapperson
Copy link
Contributor

@mattapperson mattapperson commented Nov 29, 2018 •
edited
Loading

This PR is a major step to cleaning up the code Beats CM codebase to better align to the arch docs, but also to add additional structure to the UI side that was lacking before.

This PR also:

  • cuts nearly in half the network calls we were making previously.
  • fixes a number of client side errors
  • render performance is drastically improved
  • KQL query bar now works on the tags list

Note: SOOO many files were touched here, extensive testing will be required to ensure no regressions were caused

@mattapperson
update security check from master merge
f9c2c5e
@mattapperson
aditional cleanup
bcd96e7 
# Conflicts:
#	x-pack/plugins/beats_management/public/lib/adapters/framework/adapter_types.ts
#	x-pack/plugins/beats_management/public/lib/adapters/framework/kibana_framework_adapter.ts
#	x-pack/plugins/beats_management/public/lib/lib.ts
#	x-pack/plugins/beats_management/public/router.tsx
@mattapperson
update types
a0d6dd2
@mattapperson
put the default config where it’s supposed to go
902b72d 
# Conflicts:
#	x-pack/plugins/beats_management/index.ts
@mattapperson
pages first pass
cd15eb6 
# Conflicts:
#	x-pack/plugins/beats_management/public/index.tsx
#	x-pack/plugins/beats_management/public/pages/main/walkthrough_review.tsx
#	x-pack/plugins/beats_management/public/pages/overview/finish_walkthrough.tsx
#	x-pack/plugins/beats_management/public/pages/overview/walkthrough_review.tsx
#	x-pack/plugins/beats_management/public/pages/tag.tsx
#	x-pack/plugins/beats_management/public/router.tsx
@mattapperson
wip
3509065 
# Conflicts:
#	x-pack/plugins/beats_management/public/index.tsx
#	x-pack/plugins/beats_management/public/lib/adapters/framework/kibana_framework_adapter.ts
#	x-pack/plugins/beats_management/public/lib/compose/kibana.ts
#	x-pack/plugins/beats_management/public/pages/beat/index.tsx
#	x-pack/plugins/beats_management/public/pages/overview/create_tag_fragment.tsx
#	x-pack/plugins/beats_management/public/pages/overview/enroll_fragment.tsx
#	x-pack/plugins/beats_management/public/pages/overview/enrolled_beats.tsx
#	x-pack/plugins/beats_management/public/pages/overview/index.tsx
#	x-pack/plugins/beats_management/public/pages/overview/tag_configurations.tsx
#	x-pack/plugins/beats_management/public/pages/walkthrough/initial/finish.tsx
#	x-pack/plugins/beats_management/public/router.tsx
#	x-pack/plugins/beats_management/server/lib/adapters/framework/adapter_types.ts
#	x-pack/plugins/beats_management/server/lib/adapters/framework/hapi_framework_adapter.ts
#	x-pack/plugins/canvas/scripts/peg_build.js
@mattapperson
tags container started
583101b 
# Conflicts:
#	x-pack/plugins/beats_management/public/router.tsx
@mattapperson
router is now on fleek
1ab6951
@mattapperson
fixed toast on beats page
ac02408 
# Conflicts:
#	x-pack/plugins/beats_management/common/constants/index.ts
@mattapperson
cleanup
13da819 
# Conflicts:
#	x-pack/plugins/canvas/scripts/start.js
@mattapperson
more cleanup
c9ea1c4
@mattapperson
lots more cleanup
6621b47
@mattapperson
push settings to the UI cleanly and re-add check for default user roles
bb54341
@mattapperson
cleanup beat routes
c7f58e9
@mattapperson
add route overide, fix UI access to plugin settings
e5d0763
@mattapperson
management sections now always render
04b8aa8
@mattapperson
Kibana adapter is fully typed
e91a5f6
@mattapperson
add aditional typing and validation to the ClientFramework adapter
1f65822
@mattapperson
remove some io-ts as function type is broken
9a1655e
@mattapperson
remove more io-ts
494f2e2
@mattapperson
slightly more reliable UI hooks
643fdfa
@mattapperson
Routing works
197a88a
@mattapperson
Merge branch '6.x' of github.com:elastic/kibana into refactors/lib-ad…
4ae22f8 
…apters

# Conflicts:
#	x-pack/package.json
#	x-pack/plugins/beats_management/public/index.tsx
#	x-pack/plugins/beats_management/public/pages/main/index.tsx
@mattapperson
routing now works again
733a20a
@mattapperson
All styles are now in userland vs adapter
f19cd2e
@mattapperson
assert user data for runtime
7b0b22d
@mattapperson
remove duplicate comments
98f27ce
@mattapperson
progress
fd656c0
@mattapperson
initial enroll flow working again
92033b6
@mattapperson
walkthrough finished
986a2a5
@mattapperson mattapperson mentioned this pull request Nov 29, 2018
Closed
@mattapperson
Copy link
Contributor Author

Breadcrumbs now working, also they work in-line with #25887

@mattapperson
Copy link
Contributor Author

Translations pulled in with the last merge... now time for review and bug squashing 😊

@elastic elastic deleted a comment from elasticmachine Nov 30, 2018
@elastic elastic deleted a comment from elasticmachine Nov 30, 2018
@elastic elastic deleted a comment from elasticmachine Nov 30, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mattapperson mattapperson requested review from ph and removed request for chrisronline December 3, 2018 16:52
@elasticmachine
Copy link
Contributor

💔 Build Failed

ph
ph reviewed Dec 3, 2018
View reviewed changes
x-pack/plugins/beats_management/public/lib/adapters/framework/kibana_framework_adapter.ts
const DOM_ELEMENT_NAME = this.PLUGIN_ID.replace('_', '-');
const adapter = this;
this.routes.when(
`${path}${[...Array(6)].map((e, n) => `/:arg${n}?`).join('')}`, // Hack because angular 1 does not support wildcards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add FIXME before this comment, that angular 1 reference bring back so much memories. :D

@ph
Copy link
Contributor

ph commented Dec 3, 2018

@mattapperson I did a quick look at the code, I cannot do a full review because I am not too familiar with typescript and how Kibana works I will leave that to @justinkambic.

One thing I saw is we have removed a few test files that are testing the behavior of the API is this intended? Like enroll, tokens and assign tags tests file.

@mattapperson
Copy link
Contributor Author

@mattapperson I did a quick look at the code, I cannot do a full review because I am not too familiar with typescript and how Kibana works I will leave that to @justinkambic.

One thing I saw is we have removed a few test files that are testing the behavior of the API is this intended? Like enroll, tokens and assign tags tests file.

Those files were merged and/or were empty. Additional tests will be added in a later PR so as to not make this one bigger then need be

@elastic elastic deleted a comment from elasticmachine Dec 4, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mattapperson
Copy link
Contributor Author

Closing in favor of #26636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph left review comments

@justinkambic justinkambic Awaiting requested review from justinkambic

Assignees
No one assigned
Labels
Feature:beats-cm Team:Beats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattapperson @elasticmachine @ph