[APM] Sort by score to get transaction samples with sampled:true #26389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
changed the title
💔 Build Failed |
💚 Build Succeeded |
sorenlouv
added a commit
that referenced
this pull request
Dec 4, 2018
… | [APM] Sort by score to get transaction samples with sampled:true (#26389) | [APM] Move impact calculation to Elasticsearch (#26436) (#26581) * [APM] Split API into transactions and transaction_groups (#26349) * [APM] Sort by score to get transaction samples with sampled:true (#26389) * [APM] Move impact calculation to Elasticsearch (#26436) * [APM] Move impact calculation to Elasticsearch * Renamed “durationSum” to “sum” and went back to single, mutable impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #26266.
The previous PR was supposed to have fix the issue with buckets not being highlighted.
On the Traces overview, transaction samples were sorted by date (instead of by score) so the top sample wasn't necessarily sampled.
Now transactions samples are sorted by score, and I have confirmed it to fix the problem, by manually testing with cloud data.