Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Changed 'Response Time' to 'Duration' in transactions screens #25990

Merged
merged 1 commit into from
Nov 27, 2018
Merged

[APM] Changed 'Response Time' to 'Duration' in transactions screens #25990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/components/app/TransactionDetails/Distribution/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class Distribution extends Component<Props> {
<div>
<EuiTitle size="s">
<h5>
Response time distribution{' '}
Transactions duration distribution{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I've just gotten used to "Response time distribution" but I'm not sure I'd understand what "Transactions duration distribution" was without the former.

<EuiToolTip
content={
<div>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/components/app/TransactionOverview/List/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function tpmLabel(type) {
}

function avgLabel(agentName) {
return agentName === 'js-base' ? 'Page load time' : 'Avg. resp. time';
return agentName === 'js-base' ? 'Page load time' : 'Avg. duration';
}

const TransactionNameLink = styled(RelativeLink)`
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/components/app/TransactionOverview/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class TransactionOverview extends Component {
const ChartHeaderContent =
hasDynamicBaseline && get(license.data, 'features.ml.isAvailable') ? (
<MLTipContainer>
<EuiIconTip content="The stream around the average response time shows the expected bounds. An annotation is shown for anomaly scores &gt;= 75." />
<EuiIconTip content="The stream around the average duration shows the expected bounds. An annotation is shown for anomaly scores &gt;= 75." />
<MLText>
Machine Learning:{' '}
<ViewMLJob
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/components/shared/charts/TransactionCharts/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function responseTimeLabel(type) {
case 'route-change':
return 'Route change times';
default:
return 'Response times';
return 'Transactions duration';
}
}

Expand Down