Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Translate ML - New Job(part_1) #25647

Merged
merged 71 commits into from
Dec 19, 2018
Merged

[i18n] Translate ML - New Job(part_1) #25647

merged 71 commits into from
Dec 19, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Nov 14, 2018 •
edited by maryia-lapata
Loading

Translate ml -> public -> jobs -> new_job (part_1)

Issue: #25454

Guidline
Readme

Nox911 added 23 commits September 24, 2018 18:58
@Nox911
Merge pull request #1 from elastic/master
c7ec189 
update
@Nox911
Merge pull request #2 from elastic/master
fa01b88 
second merge
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
70f6c7e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
68587a0
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
42aa7d3
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
efeaefe
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8a054ed
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b0d1660
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
62b6ad1
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
acbad4b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
a850650
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
0a200ce
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b2a8244
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b4b979e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
d349a4f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ae285b9
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
3051641
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
6231971
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f86a3d4
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
cf813c7
@Nox911
Translate ml -> new_job(part_1)
fa62520
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
1aba03f
@Nox911
Merge branch 'master' into feature/translate-ml-new_job(part_1)
15ce2cc 
# Conflicts:
#	.i18nrc.json
@Nox911 Nox911 requested a review from maryia-lapata November 14, 2018 15:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@pavel06081991
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 self-requested a review December 18, 2018 19:53
alvarezmelissa87
alvarezmelissa87 approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 6d38da4 into elastic:master Dec 19, 2018
@Nox911 Nox911 deleted the feature/translate-ml-new_job(part_1) branch December 19, 2018 10:08
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Dec 21, 2018
@Nox911 @maryia-lapata
[i18n] Translate ML - New Job(part_1) (elastic#25647)
a6fe2db 
* Translate ml -> new_job(part_1)

* resolve review comments

* resolve review comments

* move html containing directive from values

* add description to label
@maryia-lapata maryia-lapata mentioned this pull request Dec 21, 2018
Merged
Nox911 pushed a commit that referenced this pull request Dec 21, 2018
@maryia-lapata @Nox911
[i18n] Translate ML - New Job(part_1) (#25647) (#27671)
92fe016 
* Translate ml -> new_job(part_1)

* resolve review comments

* resolve review comments

* move html containing directive from values

* add description to label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 left review comments

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees
No one assigned
Labels
backported :ml Project:i18n v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nox911 @elasticmachine @pavel06081991 @alvarezmelissa87 @maryia-lapata