Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Wait for global loading indicator when creating index pattern (#25329) #25348

Merged
merged 3 commits into from
Nov 8, 2018

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Nov 7, 2018

Backports the following commits to 6.x:

@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor Author

liza-mae commented Nov 8, 2018

Looks like the test in question is now failing with a different error:

Error: retry.try timeout: [POST http://localhost:9515/session/7406f33d0c94c068c67a8fafc075a225/element/0.45282398259865353-6/clear] stale element reference: element is not attached to the page document
(Session info: headless chrome=70.0.3538.77)
(Driver info: chromedriver=2.42.591071 (0b695ff80972cc1a65a5cd643186d2ae582cd4ac),platform=Linux 4.15.0-1023-gcp x86_64)
at Server._post (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/test/functional/services/remote/verbose_remote_logging.js:34:21)
at runRequest (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/leadfoot/Session.js:92:40)
at getFinalValue (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/Promise.ts:462:22)
at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/Promise.ts:482:11
at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/Promise.ts:393:16
at runCallbacks (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/Promise.ts:11:12)
at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/Promise.ts:317:5
at run (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/Promise.ts:237:8)
at /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/node_modules/dojo/_debug/nextTick.ts:44:4
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
at lastError (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/test/common/services/retry/retry_for_success.js:29:9)
at retryForSuccess (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/test/common/services/retry/retry_for_success.js:63:13)
at

Let's test one more time if it reproduces.

Jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

liza-mae commented Nov 8, 2018

So the results are hard to interpret - not sure why adding waits would have caused earlier failures, could be the test is flaky or there are other issues with createIndexPattern - of which I have addressed more of in PR #25414 - so with both changes maybe the test will be more stable or could need more isolated investigation. Will merge along with other PR to test further on cloud and windows to see how it performs over time.

@liza-mae liza-mae merged commit 8ed79eb into elastic:6.x Nov 8, 2018
@liza-mae liza-mae deleted the backport/6.x/pr-25329 branch November 8, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants