Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Added sort order to share menu options. (#25058) #25096

Merged

Conversation

stacey-gammon
Copy link
Contributor

Backports #25058

  • Added sort order to share menu options.

Sorts ascending on sort order first then ascending on name. Any menu item without a sort order gets set to zero.

  • Moved new sortOrder property from node_modules

  • Had to rerun the snapshot for the share menu with the sortOrder in it.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

* Added sort order to share menu options.

Sorts ascending on sort order first then ascending on name. Any menu item without a sort order gets set to zero.

* Moved new sortOrder property from node_modules

* Had to rerun the snapshot for the share menu with the sortOrder in it.
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor Author


  | Test Result (2 failures / +2)UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors "before all" hookUI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors "after all" hook
-- | --



jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor Author

same failure:

UI Functional Tests.test/functional/apps/discover/_large_string·js.discover app test large strings "before all" hook
UI Functional Tests.test/functional/apps/discover/_large_string·js.discover app test large strings "after all" hook

might need to rebase

@stacey-gammon
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit 4668af3 into elastic:6.x Nov 5, 2018
@stacey-gammon stacey-gammon deleted the 6.x/order-export-report-menu branch February 12, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants