Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] [core/public/chrome] migrate controls, theme, and visibility apis (#22987) #24308

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 19, 2018

Backports the following commits to 6.x:

…astic#22987)

* [core/public/chrome] migrate controls, theme, and visibility apis

* [core/public] stop uiSettings service

* [core/public/chrome] test that observables stop immedaiately after stop()

* fix typos

* [core/public/legacyPlatform] test globalNavState init

* [ui/chrome] don't pass extra params

* [core/public/chrome] test for dedupe-handling

* [ui/chrome/theme] test with different values for logo and smallLogo
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit e33cba3 into elastic:6.x Oct 20, 2018
@spalger spalger deleted the backport/6.x/pr-22987 branch October 22, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants