-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(watch): Add WatchErrors to capture invalid watches #23887
Merged
sebelga
merged 7 commits into
elastic:master
from
sebelga:fix/Watcher-error-prevents-navigation-#20305
Oct 29, 2018
Merged
fix(watch): Add WatchErrors to capture invalid watches #23887
sebelga
merged 7 commits into
elastic:master
from
sebelga:fix/Watcher-error-prevents-navigation-#20305
Oct 29, 2018
Commits on Oct 25, 2018
-
fix(watch): Add WatchErrors to capture invalid watches
Instead of immediately throwing an error if a watch Action is invalid (email for example), we can now pass an option object to the fromUpstreamJson() method and receive back any error in the Watch. The JSON object has now a "watchErrors" object that will be used in the UI to display an error message to the user. fix(watch): Add models in public code to handle watch errors fix(watcher): Add temp styling for error messages fix(watcher): Set actionErrors to null instead of empty object when no error test(watcher): Fix broken tests after adding watchErrors prop on the Watch test(watcher): Add test for WatchError class fix(watcher): Add Watch & Action state for CONFIG_ERROR fix(watcher): move inline style to its scss file fix(watcher): Add Error display modal to show configuration errors fix(watcher): Add accesibility to errors display modal fix(Watcher): Remove table col width breaking IE layout fix(watcher): Add i18n support for errors modal title fix(Watcher): Do not throw Action error on GET calls test(Watcher): Check that correct action type is created from upstreamJson fix(Watcher): Add action instances to payload before saving Watch Angular Json editor was not sending the actions instances so no validation in Node.js was done when creating the instances on the server. Now it correctly create the action instances *before* the POST request to save/edit the Watch test(Watcher): Migrate Action server test to Jest fix(Watcher): Add warning dialog when saving a Watch with a missing 'to' field
Configuration menu - View commit details
-
Copy full SHA for 576fc51 - Browse repository at this point
Copy the full SHA 576fc51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83ffdf7 - Browse repository at this point
Copy the full SHA 83ffdf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5144dca - Browse repository at this point
Copy the full SHA 5144dcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e675ea2 - Browse repository at this point
Copy the full SHA e675ea2View commit details
Commits on Oct 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0f4245e - Browse repository at this point
Copy the full SHA 0f4245eView commit details
Commits on Oct 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1fe9b47 - Browse repository at this point
Copy the full SHA 1fe9b47View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3b614e - Browse repository at this point
Copy the full SHA a3b614eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.