Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing various issues when cloning a job using a wizard #23368

Merged
merged 1 commit into from
Sep 21, 2018
Merged

[ML] Fixing various issues when cloning a job using a wizard #23368

merged 1 commit into from
Sep 21, 2018

Conversation

jgowdyelastic
Copy link
Member

Fixes:

  • When cloning a job which uses high/low count. Count would mistakenly be used instead.
  • Cloning a distinct count job would fail.
  • When jumping from a wizard to the advanced job page, the created_by setting would be retained. Subsequent cloning of that job would cause it to use a wizard rather than the advanced page.

Fixes #23272

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.5.0 labels Sep 20, 2018
@jgowdyelastic jgowdyelastic self-assigned this Sep 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jgowdyelastic jgowdyelastic merged commit ec49c36 into elastic:master Sep 21, 2018
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 21, 2018
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 21, 2018
@jgowdyelastic
[ML] Fixing various issues when cloning a job using a wizard (elastic…
e18482d 
…#23368)
jgowdyelastic added a commit that referenced this pull request Sep 22, 2018
@jgowdyelastic
[ML] Fixing various issues when cloning a job using a wizard (#23368) (…
848de4d 
…#23412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson