Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles situations where the vislib is passed a data object with no data #2300

Merged
merged 7 commits into from
Jan 6, 2015

Conversation

stormpython
Copy link
Contributor

Closes #2297.
Closes #2428.
Closes #2347.
Closes #1887.

A message that says No results found is displayed on the screen when there are no data in the data object.

The pull request is still in the baby faze. Since I will be going away on vacation starting tomorrow, can @spenceralger and/or @jthomassie pick this one up and finish it. Thanks!

The no results message needs some work as well. See screenshot below.
screen shot 2014-12-13 at 1 39 15 am

@spalger
Copy link
Contributor

spalger commented Jan 6, 2015

LGTM 🎱

spalger pushed a commit that referenced this pull request Jan 6, 2015
Handles situations where the vislib is passed a data object with no data
@spalger spalger merged commit a4bb985 into elastic:master Jan 6, 2015
@stormpython stormpython deleted the fix/#2297 branch February 10, 2015 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment