Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds traces overview with mock data #22628

Merged
merged 14 commits into from
Sep 24, 2018
Merged

Adds traces overview with mock data #22628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d588f67
Adds traces overview with mock data
jasonrhodes Aug 31, 2018
b48ea09
Updates service overview snapshots
jasonrhodes Sep 3, 2018
2c64840
Updates based on review feedback
jasonrhodes Sep 4, 2018
fa926f6
Adds tests for ManagedTable and ImpactBar
jasonrhodes Sep 5, 2018
eea7dca
Refactored transaction overview to use new managed table component
jasonrhodes Sep 5, 2018
e62d105
Fixes tab size
jasonrhodes Sep 5, 2018
893d936
Cleans up some tests and types
jasonrhodes Sep 5, 2018
89c9b3e
Cleans up types and tests
jasonrhodes Sep 6, 2018
a805f4c
kbn bootstrap changes to x-pack yarn.lock
jasonrhodes Sep 7, 2018
0600e6e
Removed jsconfig file in apm
jasonrhodes Sep 7, 2018
531777d
Updates snapshot tests
jasonrhodes Sep 7, 2018
a1df24d
Reversed bogus yarn lock change in x-pack
jasonrhodes Sep 20, 2018
c7a39a3
review feedback wip
jasonrhodes Sep 21, 2018
05a7188
Resolves typescript issues
jasonrhodes Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"@kbn/pm": "link:packages/kbn-pm",
"@kbn/test-subj-selector": "link:packages/kbn-test-subj-selector",
"@kbn/ui-framework": "link:packages/kbn-ui-framework",
"@types/react-router-dom": "^4.3.1",
"abortcontroller-polyfill": "^1.1.9",
"angular": "1.6.9",
"angular-aria": "1.6.6",
Expand Down Expand Up @@ -236,9 +235,10 @@
"@types/node": "^8.10.20",
"@types/prop-types": "^15.5.3",
"@types/puppeteer": "^1.6.2",
"@types/react": "^16.3.14",
"@types/react": "16.3.14",
Copy link
Member Author

@jasonrhodes jasonrhodes Sep 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem here: by using ^ for this package, installing another @types/* package that depends on @types/react using the * semver range makes us upgrade to the latest version that our ranges allow, so installing @types/react-router-dom auto-upgraded this package to 16.4.x, and that version breaks a lot of our types stuff since we still use React 16.3.

Switching to ~ didn't help, because even upgrading to 16.3.18 breaks tons of our kibana typescript stuff. I don't think the @types/* packages really follow semver the same way as other packages do, similarly to how linting rulesets can't really follow semver, because every single change is most likely breaking in some way.

tl;dr since newer versions of @types/react cause lots of typescript errors in kibana, we should be explicit about the version that works with kibana and specify 16.3.14 directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Let's just double check with @spalger or @epixa to see if they have any objections.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'm going to merge this now since it's not actually changing anything with the real deps, and if there are objections or considerations we can revert the package.json change later if we need to. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections. It seems strange that it breaks so much though.

"@types/react-dom": "^16.0.5",
"@types/react-redux": "^6.0.6",
"@types/react-router-dom": "^4.3.1",
"@types/react-virtualized": "^9.18.7",
"@types/redux": "^3.6.31",
"@types/redux-actions": "^2.2.1",
Expand Down
Loading