Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract index pattern validation rules into ui/public #22606

Merged
merged 5 commits into from
Sep 4, 2018
Merged

Extract index pattern validation rules into ui/public #22606

merged 5 commits into from
Sep 4, 2018

Conversation

cjcenizal
Copy link
Contributor

This will allow us to more easily re-use these rules in rollups.

@cjcenizal cjcenizal requested a review from jen-huang August 31, 2018 20:58
jen-huang
jen-huang approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, otherwise code LGTM!

...ins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js Outdated
@@ -17,6 +17,8 @@
* under the License.
*/

export { INDEX_PATTERN_ILLEGAL_CHARACTERS } from 'ui/index_patterns';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice to import everything the wizard needs from its own constants file, but I don't love having the same object exported from 2 different places. using

import { INDEX_PATTERN_ILLEGAL_CHARACTERS as ILLEGAL_CHARACTERS } from 'ui/index_patterns';

in step_index_pattern.js instead is not much additional overhead imo

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

These tests have failed on Jenkins but I can only get a couple of them to fail locally:

21:16:54 Summary of all failing tests
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_time_field/__tests__/step_time_field.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_matched_indices.js:8:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/index.js:34:28)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_time_field/step_time_field.js:16:12)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_time_field/__tests__/step_time_field.test.js:35:24)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/__tests__/step_index_pattern.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.js:16:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/__tests__/step_index_pattern.test.js:46:27)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/create_index_pattern_wizard.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_matched_indices.js:8:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/index.js:34:28)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/create_index_pattern_wizard.js:16:12)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/create_index_pattern_wizard.test.js:39:36)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/__tests__/indices_list.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/indices_list.js:16:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/__tests__/indices_list.test.js:7:21)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/render.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_matched_indices.js:8:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/index.js:34:28)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/create_index_pattern_wizard.js:16:12)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/render.js:15:36)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/render.test.js:31:146)
21:16:54 
21:16:54 
21:16:54 Test Suites: 5 failed, 1 skipped, 465 passed, 470 of 471 total

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit bcb7938 into elastic:master Sep 4, 2018
@cjcenizal cjcenizal deleted the chore/extract-index-pattern-rules branch September 4, 2018 18:27
@cjcenizal cjcenizal mentioned this pull request Sep 4, 2018
Merged
cjcenizal added a commit that referenced this pull request Sep 5, 2018
@cjcenizal
Extract index pattern validation rules into ui/public (#22606) (#22680)
3cf9144 
* Rename containsInvalidCharacters to containsIllegalCharacters and return a value which accurately reflects the name.
* Move illegal index pattern characters from Management into ui/public/index_patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees
No one assigned
Labels
chore v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @elasticmachine @jen-huang