Beats/config view #22177

…tic#20039) * [Beats Management] Initial scaffolding for plugin (elastic#18977) * Initial scaffolding for Beats plugin * Removing bits not (yet) necessary in initial scaffolding * [Beats Management] Install Beats index template on plugin init (elastic#19072) * Install Beats index template on plugin init * Adding missing files * [Beats Management] APIs: Create enrollment tokens (elastic#19018) * WIP checkin * Register API routes * Fixing typo in index name * Adding TODOs * Removing commented out license checking code that isn't yet implemented * Remove unnecessary async/await * Don't return until indices have been refreshed * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Adding TODO * Fixing variable name * Using a single index * Adding expiration date field * Adding test for expiration date field * Ignore non-existent index * Fixing logic in test * Creating constant for default enrollment tokens TTL value * Updating test * Fixing name of test file (elastic#19100) * [Beats Management] APIs: Enroll beat (elastic#19056) * WIP checkin * Add API integration test * Converting to Jest test * Create API for enrolling a beat * Handle invalid or expired enrollment tokens * Use create instead of index to prevent same beat from being enrolled twice * Adding unit test for duplicate beat enrollment * Do not persist enrollment token with beat once token has been checked and used * Fix datatype of host_ip field * Make Kibana API guess host IP instead of requiring it in payload * Fixing error introduced in rebase conflict resolution * [Beats Management] APIs: List beats (elastic#19086) * WIP checkin * Add API integration test * Converting to Jest test * WIP checkin * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Updating mapping * [Beats Management] APIs: Verify beats (elastic#19103) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Fleshing out remaining tests * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Moving TODO comment to right file * Rename determine* helper functions to find* * Fixing assertions (elastic#19194) * [Beats Management] APIs: Update beat (elastic#19148) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Add API tests * Update template to allow version field for beat * Implement PUT /api/beats/agent/{beat ID} API * Make enroll beat code consistent with update beat code * Fixing minor typo in TODO comment * Allow version in request payload * Make sure beat is not updated in ES in error scenarios * Adding version as required field in Enroll Beat API payload * Using destructuring * Fixing rename that was accidentally reversed in conflict fixing * [Beats Management] APIs: take auth tokens via headers (elastic#19210) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Make "Enroll Beat" API take enrollment token via header instead of request body * Make "Update Beat" API take access token via header instead of request body * [Beats Management] APIs: Create configuration block (elastic#19270) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Implementing POST /api/beats/configuration_blocks API * Removing unnecessary escaping * Fleshing out types + adding validation for them * Making output singular (was outputs) * Removing metricbeat.inputs * Revert implementation of `POST /api/beats/configuration_blocks` API (elastic#19340) This API allowed the user to operate at a level of abstraction that is unnecessarily and dangerously too low. A better API would be at one level higher, where users can create, update, and delete tags (where a tag can contain multiple configuration blocks). * [Beats Management] APIs: Create or update tag (elastic#19342) * Updating mappings * Implementing PUT /api/beats/tag/{tag} API * [Beats Management] Prevent timing attacks when checking auth tokens (elastic#19363) * Using crypto.timingSafeEqual() for comparing auth tokens * Prevent subtler timing attack in token comparison function * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * [Beats Management] APIs: Assign tag(s) to beat(s) (elastic#19431) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Rename "determine" to "find" * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Updating ES archive * Renaming * Use destructuring * Moving start of script to own line to increase readability * Using destructuring * [Beats Management] APIs: Remove tag(s) from beat(s) (elastic#19440) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Renaming * Use destructuring * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Implementing `POST /api/beats/agents_tags/removals` API * Updating ES archive * Use destructuring * Moving start of script to own line to increase readability * Nothing to remove if there are no existing tags! * Updating tests to match changes in bulk update painless script * Use destructuring * Ported over base types and arch structure * move management of installIndexTemplate into the framework adapter * ts-lint fix * tslint fixes * more ts tweaks * fix paths * added several working endpoints * add more routes and bug fixes * fix linting * fix type remove CRUFT * remove more cruft * remove more CRUFT * added comments, change plurality * add tsconfig file * add extends path * fixed typo * serveral PR review fixes * fixed lodash type version * “fix” types by applying a lot of any

… selected

…tic#20039) * [Beats Management] Initial scaffolding for plugin (elastic#18977) * Initial scaffolding for Beats plugin * Removing bits not (yet) necessary in initial scaffolding * [Beats Management] Install Beats index template on plugin init (elastic#19072) * Install Beats index template on plugin init * Adding missing files * [Beats Management] APIs: Create enrollment tokens (elastic#19018) * WIP checkin * Register API routes * Fixing typo in index name * Adding TODOs * Removing commented out license checking code that isn't yet implemented * Remove unnecessary async/await * Don't return until indices have been refreshed * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Adding TODO * Fixing variable name * Using a single index * Adding expiration date field * Adding test for expiration date field * Ignore non-existent index * Fixing logic in test * Creating constant for default enrollment tokens TTL value * Updating test * Fixing name of test file (elastic#19100) * [Beats Management] APIs: Enroll beat (elastic#19056) * WIP checkin * Add API integration test * Converting to Jest test * Create API for enrolling a beat * Handle invalid or expired enrollment tokens * Use create instead of index to prevent same beat from being enrolled twice * Adding unit test for duplicate beat enrollment * Do not persist enrollment token with beat once token has been checked and used * Fix datatype of host_ip field * Make Kibana API guess host IP instead of requiring it in payload * Fixing error introduced in rebase conflict resolution * [Beats Management] APIs: List beats (elastic#19086) * WIP checkin * Add API integration test * Converting to Jest test * WIP checkin * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Updating mapping * [Beats Management] APIs: Verify beats (elastic#19103) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Fleshing out remaining tests * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Moving TODO comment to right file * Rename determine* helper functions to find* * Fixing assertions (elastic#19194) * [Beats Management] APIs: Update beat (elastic#19148) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Add API tests * Update template to allow version field for beat * Implement PUT /api/beats/agent/{beat ID} API * Make enroll beat code consistent with update beat code * Fixing minor typo in TODO comment * Allow version in request payload * Make sure beat is not updated in ES in error scenarios * Adding version as required field in Enroll Beat API payload * Using destructuring * Fixing rename that was accidentally reversed in conflict fixing * [Beats Management] APIs: take auth tokens via headers (elastic#19210) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Make "Enroll Beat" API take enrollment token via header instead of request body * Make "Update Beat" API take access token via header instead of request body * [Beats Management] APIs: Create configuration block (elastic#19270) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Implementing POST /api/beats/configuration_blocks API * Removing unnecessary escaping * Fleshing out types + adding validation for them * Making output singular (was outputs) * Removing metricbeat.inputs * Revert implementation of `POST /api/beats/configuration_blocks` API (elastic#19340) This API allowed the user to operate at a level of abstraction that is unnecessarily and dangerously too low. A better API would be at one level higher, where users can create, update, and delete tags (where a tag can contain multiple configuration blocks). * [Beats Management] APIs: Create or update tag (elastic#19342) * Updating mappings * Implementing PUT /api/beats/tag/{tag} API * [Beats Management] Prevent timing attacks when checking auth tokens (elastic#19363) * Using crypto.timingSafeEqual() for comparing auth tokens * Prevent subtler timing attack in token comparison function * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * [Beats Management] APIs: Assign tag(s) to beat(s) (elastic#19431) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Rename "determine" to "find" * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Updating ES archive * Renaming * Use destructuring * Moving start of script to own line to increase readability * Using destructuring * [Beats Management] APIs: Remove tag(s) from beat(s) (elastic#19440) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Renaming * Use destructuring * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Implementing `POST /api/beats/agents_tags/removals` API * Updating ES archive * Use destructuring * Moving start of script to own line to increase readability * Nothing to remove if there are no existing tags! * Updating tests to match changes in bulk update painless script * Use destructuring * Ported over base types and arch structure * move management of installIndexTemplate into the framework adapter * ts-lint fix * tslint fixes * more ts tweaks * fix paths * added several working endpoints * add more routes and bug fixes * fix linting * fix type remove CRUFT * remove more cruft * remove more CRUFT * added comments, change plurality * add tsconfig file * add extends path * fixed typo * serveral PR review fixes * fixed lodash type version * “fix” types by applying a lot of any

* [ML] Fixing issue with historical job audit messages (elastic#21718) * Add proper aria-label for close inspector (elastic#21719) * [Beats Management] Initial scaffolding for plugin (elastic#18977) * Initial scaffolding for Beats plugin * Removing bits not (yet) necessary in initial scaffolding * [Beats Management] Install Beats index template on plugin init (elastic#19072) * Install Beats index template on plugin init * Adding missing files * [Beats Management] APIs: Create enrollment tokens (elastic#19018) * WIP checkin * Register API routes * Fixing typo in index name * Adding TODOs * Removing commented out license checking code that isn't yet implemented * Remove unnecessary async/await * Don't return until indices have been refreshed * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Adding TODO * Fixing variable name * Using a single index * Adding expiration date field * Adding test for expiration date field * Ignore non-existent index * Fixing logic in test * Creating constant for default enrollment tokens TTL value * Updating test * Fixing name of test file (elastic#19100) * [Beats Management] APIs: Enroll beat (elastic#19056) * WIP checkin * Add API integration test * Converting to Jest test * Create API for enrolling a beat * Handle invalid or expired enrollment tokens * Use create instead of index to prevent same beat from being enrolled twice * Adding unit test for duplicate beat enrollment * Do not persist enrollment token with beat once token has been checked and used * Fix datatype of host_ip field * Make Kibana API guess host IP instead of requiring it in payload * Fixing error introduced in rebase conflict resolution * [Beats Management] APIs: List beats (elastic#19086) * WIP checkin * Add API integration test * Converting to Jest test * WIP checkin * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Updating mapping * [Beats Management] APIs: Verify beats (elastic#19103) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Fleshing out remaining tests * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Moving TODO comment to right file * Rename determine* helper functions to find* * Fixing assertions (elastic#19194) * [Beats Management] APIs: Update beat (elastic#19148) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Add API tests * Update template to allow version field for beat * Implement PUT /api/beats/agent/{beat ID} API * Make enroll beat code consistent with update beat code * Fixing minor typo in TODO comment * Allow version in request payload * Make sure beat is not updated in ES in error scenarios * Adding version as required field in Enroll Beat API payload * Using destructuring * Fixing rename that was accidentally reversed in conflict fixing * [Beats Management] APIs: take auth tokens via headers (elastic#19210) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Make "Enroll Beat" API take enrollment token via header instead of request body * Make "Update Beat" API take access token via header instead of request body * [Beats Management] APIs: Create configuration block (elastic#19270) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Implementing POST /api/beats/configuration_blocks API * Removing unnecessary escaping * Fleshing out types + adding validation for them * Making output singular (was outputs) * Removing metricbeat.inputs * Revert implementation of `POST /api/beats/configuration_blocks` API (elastic#19340) This API allowed the user to operate at a level of abstraction that is unnecessarily and dangerously too low. A better API would be at one level higher, where users can create, update, and delete tags (where a tag can contain multiple configuration blocks). * [Beats Management] APIs: Create or update tag (elastic#19342) * Updating mappings * Implementing PUT /api/beats/tag/{tag} API * [Beats Management] Prevent timing attacks when checking auth tokens (elastic#19363) * Using crypto.timingSafeEqual() for comparing auth tokens * Prevent subtler timing attack in token comparison function * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * [Beats Management] APIs: Assign tag(s) to beat(s) (elastic#19431) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Rename "determine" to "find" * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Updating ES archive * Renaming * Use destructuring * Moving start of script to own line to increase readability * Using destructuring * [Beats Management] APIs: Remove tag(s) from beat(s) (elastic#19440) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Renaming * Use destructuring * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Implementing `POST /api/beats/agents_tags/removals` API * Updating ES archive * Use destructuring * Moving start of script to own line to increase readability * Nothing to remove if there are no existing tags! * Updating tests to match changes in bulk update painless script * Use destructuring * [Beats Management] Move to Ingest UI arch and initial TS effort (elastic#20039) * [Beats Management] Initial scaffolding for plugin (elastic#18977) * Initial scaffolding for Beats plugin * Removing bits not (yet) necessary in initial scaffolding * [Beats Management] Install Beats index template on plugin init (elastic#19072) * Install Beats index template on plugin init * Adding missing files * [Beats Management] APIs: Create enrollment tokens (elastic#19018) * WIP checkin * Register API routes * Fixing typo in index name * Adding TODOs * Removing commented out license checking code that isn't yet implemented * Remove unnecessary async/await * Don't return until indices have been refreshed * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Adding TODO * Fixing variable name * Using a single index * Adding expiration date field * Adding test for expiration date field * Ignore non-existent index * Fixing logic in test * Creating constant for default enrollment tokens TTL value * Updating test * Fixing name of test file (elastic#19100) * [Beats Management] APIs: Enroll beat (elastic#19056) * WIP checkin * Add API integration test * Converting to Jest test * Create API for enrolling a beat * Handle invalid or expired enrollment tokens * Use create instead of index to prevent same beat from being enrolled twice * Adding unit test for duplicate beat enrollment * Do not persist enrollment token with beat once token has been checked and used * Fix datatype of host_ip field * Make Kibana API guess host IP instead of requiring it in payload * Fixing error introduced in rebase conflict resolution * [Beats Management] APIs: List beats (elastic#19086) * WIP checkin * Add API integration test * Converting to Jest test * WIP checkin * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Updating mapping * [Beats Management] APIs: Verify beats (elastic#19103) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Fleshing out remaining tests * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Moving TODO comment to right file * Rename determine* helper functions to find* * Fixing assertions (elastic#19194) * [Beats Management] APIs: Update beat (elastic#19148) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Add API tests * Update template to allow version field for beat * Implement PUT /api/beats/agent/{beat ID} API * Make enroll beat code consistent with update beat code * Fixing minor typo in TODO comment * Allow version in request payload * Make sure beat is not updated in ES in error scenarios * Adding version as required field in Enroll Beat API payload * Using destructuring * Fixing rename that was accidentally reversed in conflict fixing * [Beats Management] APIs: take auth tokens via headers (elastic#19210) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Make "Enroll Beat" API take enrollment token via header instead of request body * Make "Update Beat" API take access token via header instead of request body * [Beats Management] APIs: Create configuration block (elastic#19270) * WIP checkin * WIP checkin * Add API integration test * Converting to Jest test * Fixing API for default case + adding test for it * Fixing copy pasta typos * Fixing variable name * Using a single index * Implementing GET /api/beats/agents API * Creating POST /api/beats/agents/verify API * Refactoring: extracting out helper functions * Expanding TODO note so I won't forget :) * Fixing file name * Updating mapping * Fixing minor typo in TODO comment * Implementing POST /api/beats/configuration_blocks API * Removing unnecessary escaping * Fleshing out types + adding validation for them * Making output singular (was outputs) * Removing metricbeat.inputs * Revert implementation of `POST /api/beats/configuration_blocks` API (elastic#19340) This API allowed the user to operate at a level of abstraction that is unnecessarily and dangerously too low. A better API would be at one level higher, where users can create, update, and delete tags (where a tag can contain multiple configuration blocks). * [Beats Management] APIs: Create or update tag (elastic#19342) * Updating mappings * Implementing PUT /api/beats/tag/{tag} API * [Beats Management] Prevent timing attacks when checking auth tokens (elastic#19363) * Using crypto.timingSafeEqual() for comparing auth tokens * Prevent subtler timing attack in token comparison function * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * [Beats Management] APIs: Assign tag(s) to beat(s) (elastic#19431) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Rename "determine" to "find" * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Updating ES archive * Renaming * Use destructuring * Moving start of script to own line to increase readability * Using destructuring * [Beats Management] APIs: Remove tag(s) from beat(s) (elastic#19440) * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Remove random delay * Starting to implement POST /api/beats/beats_tags API * Changing API * Updating tests for changes to API * Renaming * Use destructuring * Using crypto.timingSafeEqual() for comparing auth tokens * Introduce random delay after we try to find token in ES to mitigate timing attack * Implementing `POST /api/beats/agents_tags/removals` API * Updating ES archive * Use destructuring * Moving start of script to own line to increase readability * Nothing to remove if there are no existing tags! * Updating tests to match changes in bulk update painless script * Use destructuring * Ported over base types and arch structure * move management of installIndexTemplate into the framework adapter * ts-lint fix * tslint fixes * more ts tweaks * fix paths * added several working endpoints * add more routes and bug fixes * fix linting * fix type remove CRUFT * remove more cruft * remove more CRUFT * added comments, change plurality * add tsconfig file * add extends path * fixed typo * serveral PR review fixes * fixed lodash type version * “fix” types by applying a lot of any * [Beats Management] Move tokens to use JWT, add more complete test suite (elastic#20317) * inital effort to move to JWT and added jest based tests on libs * assign beats tests all passing * token tests now pass * add more tests * all tests now green * fix broken test, this is beats CM not logstash 😊 * added readme * move enrollment token back to a hash * remove un-needed comment * alias lodash get to avoid confusion * isolated hash creation * [Beats Management] add more tests, update types, break out ES into it's own adapter (elastic#20566) * inital effort to move to JWT and added jest based tests on libs * assign beats tests all passing * token tests now pass * add more tests * all tests now green * move enrollment token back to a hash * remove un-needed comment * alias lodash get to avoid confusion * isolated hash creation * Add initial efforts for backend framework adapter testing * move ES code to a DatabaseAdapter from BackendAdapter and add a TON of types for ES * re-typed * renamed types to match pattern * aditional renames * adapter tests should always just use adapterSetup(); * database now uses InternalRequest * corrected spelling of framework * fix typings * remove CRUFT * RequestOrInternal * Dont pass around request objects everywhere, just pass the user. Also, removed hapi types as they were not compatible * fix tests, add test, removed extra comment * fix auth * updated lock file * [Beats Management] add get beat endpoint (elastic#20603) * [Beats Management] Move tokens to use JWT, add more complete test suite (elastic#20317) * inital effort to move to JWT and added jest based tests on libs * assign beats tests all passing * token tests now pass * add more tests * all tests now green * fix broken test, this is beats CM not logstash 😊 * added readme * move enrollment token back to a hash * remove un-needed comment * alias lodash get to avoid confusion * isolated hash creation * inital effort to move to JWT and added jest based tests on libs * assign beats tests all passing * token tests now pass * add more tests * all tests now green * move enrollment token back to a hash * remove un-needed comment * alias lodash get to avoid confusion * isolated hash creation * Add initial efforts for backend framework adapter testing * move ES code to a DatabaseAdapter from BackendAdapter and add a TON of types for ES * re-typed * renamed types to match pattern * aditional renames * adapter tests should always just use adapterSetup(); * database now uses InternalRequest * corrected spelling of framework * fix typings * remove CRUFT * RequestOrInternal * Dont pass around request objects everywhere, just pass the user. Also, removed hapi types as they were not compatible * fix tests, add test, removed extra comment * Moved critical path code from route, to more easeley tested domain * fix auth * remove beat verification, added get beat endpoint to return configs * fix type * update createGetBeatConfigurationRoute URL * rename method * update to match PR elastic#20566 * updated lock file * fix bad merge * update TSLinting * fix bad rebase * [Beats Management] [WIP] Create public resources for management plugin (elastic#20864) * Init plugin public resources. * rename beats to beats_management * rendering react now * Beats/initial ui (elastic#20994) * initial layout and main nav * modal UI and pattern for UI established * fix path * wire up in-memroy adapters * tweak adapters * add getAll method to tags adapter (elastic#21287) * Beats/real adapters (elastic#21481) * add initial real adapters, and nulled data where we need endpoints * UI adapters and needed endpoints added (though not tested) * prep for route tests and some cleanup * move files * [Beats Management] Add BeatsTable/Bulk Action Search Component (elastic#21182) * Add BeatsTable and control bar components. * Clean yarn.lock. * Move raw numbers/strings to constants. Remove obsolete state/props. * Update/add tests. * Change prop name from "items" to "beats". * Rename some variables. * Move search bar filter definitions to table render. * Update table to support assignment options. * Update action control position. * Refactor split render function into custom components. * Beats/basic use cases (elastic#21660) * tweak adapter responses / types. re-add enroll ui * routes enabled, enroll now pings the server * full enrollment path now working * improved pinging for beat enrollment * fix location of history call * reload beats list on beat enrollment completion * add update on client side, expand update on server to allow for partial data, and user auth * remove double beat lookup * fix tests * only return active beats * disenroll now working * fig getAll query * re-enrolling a beat will now work * fix types * fix types * update deps * update kibana API for version

…anging the tag id

… blocks

elasticmachine · 2018-08-27T17:37:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-27T23:02:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

justinkambic

I asked for a few minor changes but on the whole it seems like a huge step.

justinkambic · 2018-08-27T19:29:43Z

x-pack/plugins/beats_management/public/components/inputs/code.tsx

@@ -0,0 +1,115 @@
+/*


Can we rename this file to code_editor.tsx? Normally I wouldn't mind but a name of simply code seems a bit ambiguous to me.

justinkambic · 2018-08-27T22:02:03Z

x-pack/plugins/beats_management/public/components/inputs/input.tsx

+  public handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
+    const { value } = e.currentTarget;
+    this.props.setValue(value);
+    if (this.props.onChange) {


We're requiring the parent to provide a function for this prop - is it a best practice in TS to check if a variable is falsey even if it's required?

bad types on my part, they should be optional

justinkambic · 2018-08-27T22:03:05Z

x-pack/plugins/beats_management/public/components/inputs/input.tsx

+
+  public handleBlur = (e: React.ChangeEvent<HTMLInputElement>) => {
+    this.showError();
+    if (this.props.onBlur) {


Same question as in handleChange.

justinkambic · 2018-08-27T22:07:30Z

x-pack/plugins/beats_management/public/components/inputs/multi_input.tsx

+  public handleChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => {
+    const { value } = e.currentTarget;
+    this.props.setValue(value);
+    if (this.props.onChange) {


Same question as the handlers in FieldText

justinkambic · 2018-08-27T22:10:37Z

x-pack/plugins/beats_management/public/components/table/table_type_configs.tsx

-            ? `${tag.id.substring(0, TABLE_CONFIG.TRUNCATE_TAG_LENGTH)}...`
-            : tag.id}
-        </EuiBadge>
+        <ConnectedLink path={`/tag/edit/${tag.id}`}>


justinkambic · 2018-08-27T22:19:08Z

x-pack/plugins/beats_management/public/components/tag/config_view/config_form.tsx

+});
+
+addValidationRule('isPeriod', (values: FormData, value: FieldValue) => {
+  // TODO add more validation


Is it worthwhile to add a new issue for the project to track the improvement of input validation?

Probably, I plan to run a script I have to look for TODOs to add as phase 2 tasks

In that case we can just let it go until you're ready for that 👍

justinkambic · 2018-08-27T22:23:15Z

x-pack/plugins/beats_management/public/components/tag/config_view/config_form.tsx

+          onValid={this.enableButton}
+          onInvalid={this.disableButton}
+        >
+          {this.props.schema.map(schema => {


justinkambic · 2018-08-27T22:26:44Z

x-pack/plugins/beats_management/public/components/tag/config_view/index.tsx

+            />
+          </EuiFormRow>
+          <h3>
+            Config for{' '}


Would   be more preferable here?

justinkambic · 2018-08-27T22:46:13Z

x-pack/plugins/beats_management/public/config_schemas.ts

+  },
+];
+
+// const outputConfig: YamlConfigSchema[] = [


Can we have a comment explaining why this needs to stay here?

eh, maybe lol... its a config block we might or might not use (beats supporting this is not yet known). Once we know ill uncomment or remove

Ok, no problem.

justinkambic · 2018-08-27T22:47:29Z

x-pack/plugins/beats_management/public/config_schemas.ts

+
+import { YamlConfigSchema } from './lib/lib';
+
+const filebeatInputConfig: YamlConfigSchema[] = [


Ok - just a check to make sure I understand how this is being approached:

Each supported Beat type has its own set of config schemas

The schemas define the type of input and supply any needed options, etc.

These schemas' instructions will correspond to the inputs defined and rendered in the classes above in the inputs dir

justinkambic · 2018-08-27T23:23:08Z

Trying to functional review off of commit 8436fc333403af88e764667f709e9243d3ad97d8.

Beats Management isn't showing up under the management screen anymore.

elasticmachine · 2018-08-28T00:43:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

justinkambic

Code looks ok to me now (excepting the optional fields on the remaining input types), still getting an issue with functional checks though, will explain in a separate comment.

justinkambic · 2018-08-28T02:50:20Z

x-pack/plugins/beats_management/public/components/inputs/code_editor.tsx

+  fullWidth: boolean;
+  helpText: React.ReactElement<any>;
+  compressed: boolean;
+  onChange(value: string): void;


Make these optional - sorry, should have commented here before as well

justinkambic · 2018-08-28T02:50:52Z

x-pack/plugins/beats_management/public/components/inputs/multi_input.tsx

+  fullWidth: boolean;
+  helpText: React.ReactElement<any>;
+  compressed: boolean;
+  onChange(e: React.ChangeEvent<HTMLTextAreaElement>, value: any): void;


Make optional - sorry, should have commented here before as well

justinkambic · 2018-08-28T02:51:46Z

x-pack/plugins/beats_management/public/components/inputs/select.tsx

+  fullWidth: boolean;
+  helpText: React.ReactElement<any>;
+  compressed: boolean;
+  onChange(e: React.ChangeEvent<HTMLInputElement>, value: any): void;


Make optional - sorry, should have commented here before as well

justinkambic · 2018-08-28T02:55:01Z

x-pack/plugins/beats_management/public/components/inputs/select.tsx

+    }
+  }
+
+  public handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {


The repetition of this code makes me question if it'd be worth refactoring these classes to reduce the amount of shared code maintained in each class, in a later PR. I'm sure it's crossed your mind, did you have thoughts on that?

justinkambic · 2018-08-28T02:55:34Z

x-pack/plugins/beats_management/public/components/tag/config_view/config_form.tsx

+});
+
+addValidationRule('isPeriod', (values: FormData, value: FieldValue) => {
+  // TODO add more validation


In that case we can just let it go until you're ready for that 👍

justinkambic · 2018-08-28T02:56:19Z

x-pack/plugins/beats_management/public/config_schemas.ts

+  },
+];
+
+// const outputConfig: YamlConfigSchema[] = [


Ok, no problem.

justinkambic · 2018-08-28T03:25:28Z

Let me preface this by saying that everything else works as I expected. When this problem is fixed and the changes I asked for, if you agree with them, are made, you can consider this comment a successful LGTM and merge so you're no longer blocked.

Issue

Previous issue (no CM link on Management plugin) was resolved, but when I am creating a tag now I run into some problems.

Repro Steps

Load up CM
Navigate to the Tag list
Click Create Tag
Specify a name for the tag
Specify a color
Click Add a new configuration
Select Metricbeat module
Enter some description text
Attempt to choose a system type from the select menu

At this point my selection appears not to be saved.

Warning

React provides a warning that likely accompanies the bug:

warning.js:33 Warning: A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
    in input (created by EuiValidatableControl)
    in EuiValidatableControl (created by EuiFieldText)
    in div (created by EuiFormControlLayout)
    in div (created by EuiFormControlLayout)
    in EuiFormControlLayout (created by EuiFieldText)
    in EuiFieldText (created by ConfigView)
    in div (created by EuiFormRow)
    in EuiFormRow (created by ConfigView)
    in div (created by EuiFlyoutBody)
    in EuiFlyoutBody (created by ConfigView)
    in div (created by EuiFlyout)
    in div (created by FocusTrap)
    in FocusTrap (created by EuiFlyout)
    in span (created by EuiFlyout)
    in EuiFlyout (created by ConfigView)
    in ConfigView (created by TagEdit)
    in div (created by TagEdit)
    in TagEdit (created by TagPage)
    in div (created by TagPage)
    in div (created by EuiPageContentBody)
    in EuiPageContentBody
    in div (created by EuiPanel)
    in EuiPanel (created by EuiPageContent)
    in EuiPageContent
    in div (created by EuiPageBody)
    in EuiPageBody
    in div (created by EuiPage)
    in EuiPage
    in Unknown (created by Route)
    in Route (created by withRouter())
    in withRouter() (created by TagPage)
    in TagPage (created by Route)
    in Route (created by PageRouter)
    in Switch (created by PageRouter)
    in Router (created by HashRouter)
    in HashRouter (created by PageRouter)
    in PageRouter

I've seen this a few times when working with form elements myself.

Screenshots

After Failed Selection

Attempting to Save

elasticmachine · 2018-08-28T11:56:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

justinkambic

Functionally working now!
LGTM!

mattapperson added :Ingest UI Feature:beats-cm labels Aug 20, 2018

mattapperson force-pushed the feature/x-pack/management/beats branch from 9b4aa7d to cd8f274 Compare August 27, 2018 17:04

mattapperson added 17 commits August 27, 2018 13:27

add details page, re-configure routes

ebffb62

move tag crud to new route stuff

85c1e59

update tag create/edit component api

e782314

tags creation now working

2151ae3

bunch of stuff I should have split up better…

7ab3a96

fixed perf bug, selected items that are removed are no longer phantom…

c2d3a4a

… selected

fix rendering of assignments

8317937

remove assign to beats, the UX was too poor

c1ebd16

progress on config forms

b071284

config view inital input types working

6298c2f

ts fixes

b8c0605

fix more ts

d628018

code now errors on invalid yaml

9373a2c

remove un-needed include

b533c30

mattapperson added 12 commits August 27, 2018 13:29

vis name validation for tag

aac2b30

update EUI style

22c358d

tweak design

4cd93aa

fixed tag assignments (still has a ui glitch)

9888cf5

fix form validation on select

4e25282

fix deps

00e826a

update deps

48f3497

attached beats now works in the edit tag screen, edit now disables ch…

d44f2f4

…anging the tag id

better un-parsing of yaml, some elements now rendering to edit config…

29a5f07

… blocks

delete config block now works

4679e91

fix ability to edit config

6a88c35

fix deps

0103aea

mattapperson force-pushed the beats/config-view branch from e3256ac to 0103aea Compare August 27, 2018 17:30

mattapperson requested a review from justinkambic August 27, 2018 17:32

fix another rebase issue

d0502fe

justinkambic requested changes Aug 27, 2018

View reviewed changes

tweaks and fixes

57fdb5b

justinkambic reviewed Aug 28, 2018

View reviewed changes

fix several bugs

dfa443f

justinkambic approved these changes Aug 28, 2018

View reviewed changes

mattapperson merged commit b0f0848 into elastic:feature/x-pack/management/beats Aug 28, 2018


		import { YamlConfigSchema } from './lib/lib';

		const filebeatInputConfig: YamlConfigSchema[] = [

Beats/config view #22177

Beats/config view #22177

Conversation

mattapperson commented Aug 20, 2018 • edited Loading

elasticmachine commented Aug 20, 2018

💔 Build Failed

elasticmachine commented Aug 20, 2018

💔 Build Failed

elasticmachine commented Aug 21, 2018

💔 Build Failed

elasticmachine commented Aug 21, 2018

💔 Build Failed

elasticmachine commented Aug 24, 2018

💔 Build Failed

elasticmachine commented Aug 24, 2018

💔 Build Failed

elasticmachine commented Aug 24, 2018

💔 Build Failed

elasticmachine commented Aug 27, 2018

💔 Build Failed

elasticmachine commented Aug 27, 2018

💔 Build Failed

elasticmachine commented Aug 27, 2018

💔 Build Failed

elasticmachine commented Aug 27, 2018

💔 Build Failed

justinkambic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinkambic commented Aug 27, 2018

elasticmachine commented Aug 28, 2018

💔 Build Failed

justinkambic left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinkambic commented Aug 28, 2018

Issue

Repro Steps

Warning

Screenshots

After Failed Selection

Attempting to Save

elasticmachine commented Aug 28, 2018

💔 Build Failed

justinkambic left a comment

Choose a reason for hiding this comment

mattapperson commented Aug 20, 2018 •

edited

Loading

justinkambic left a comment •

edited

Loading