Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper aria-label for close inspector #21719

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Add proper aria-label for close inspector #21719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ui/public/flyout/flyout_session.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class FlyoutSession extends EventEmitter {
export function openFlyout(
flyoutChildren: React.ReactNode,
flyoutProps: {
closeButtonAriaLabel?: string;
onClose?: () => void;
'data-test-subj'?: string;
} = {}
Expand Down
1 change: 1 addition & 0 deletions src/ui/public/inspector/inspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ function open(adapters: Adapters, options: InspectorOptions = {}): InspectorSess

return openFlyout(<InspectorPanel views={views} adapters={adapters} title={options.title} />, {
'data-test-subj': 'inspectorPanel',
closeButtonAriaLabel: 'Close Inspector',
});
}

Expand Down