[6.x] [kbn-test] convert kibana-install-dir flag to installDir option (#21317) #21626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#21317) * [kbn-test] convert kibana-install-dir flag to installDir option * [kbn-test] replicate kibana-install-dir handling to startServers * [ftr] try running functional tests in production in CI * Revert "[ftr] try running functional tests in production in CI" This reverts commit e5b94aa. * [core/public/legacyPlatform] exclude ui/test_harness from the distributable * [optimizer] fix `process.env.IS_KIBANA_DISTRIBUTABLE` definition * [optimizer] only define `process.env.IS_KIBANA_DISTRIBUTABLE` when needed Adding a `webpack.DefinePlugin` slows down the optimizer a small amount, so only apply it when it is necessary, and skip it if it is going to be defined as "false". * [kbn-test/startServer] don't run in --dev mode if running from dist * [ftr/kibanaServer/version] attach `-SNAPSHOT` suffix to version if running build_snapshot
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: