[config] logging.useUTC -> logging.timezone #21561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
review
Team:Core
💔 Build Failed |
tylersmalley
reviewed
Aug 1, 2018
docs/setup/settings.asciidoc
Outdated
| @@ -73,7 +73,7 @@ error messages. | |||
|
|
|||
| [[logging-verbose]]`logging.verbose:`:: *Default: false* Set the value of this setting to `true` to log all events, including system usage information and all requests. Supported on Elastic Cloud Enterprise. | |||
|
|
|||
| `logging.useUTC`:: *Default: true* Set the value of this setting to `false` to log events using the timezone of the server, rather than UTC. | |||
| `logging.timezone`:: *Default: UTC* Set to the canonical timezone id to log events using that timezone. | |||
There was a problem hiding this comment.
Can we link here? https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
And provide an example like US/Pacific?
I am concerned that folks will not easily understand what the "canonical timezone id" they need to provide would be.
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
|
Looks like there is a conflict with the docs. Want to resolve that and merge this PR? |
💚 Build Succeeded |
This reverts commit f6e9090833a5180fe360a9ff54543c37c0ca3a58.
💚 Build Succeeded |
|
@jbudz What's the status here? |
|
good to go, i'm going to do a fresh ci run with master merged and then i'll get it committted |
💚 Build Succeeded |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Sep 4, 2018
* [config] logging.useUTC -> logging.timezone * docs * [env] exit if starting as root * fix import path * add link and timezone example * Revert "[env] exit if starting as root" This reverts commit f6e9090833a5180fe360a9ff54543c37c0ca3a58.
jbudz
added a commit
that referenced
this pull request
Sep 5, 2018
* [config] logging.useUTC -> logging.timezone * docs * [env] exit if starting as root * fix import path * add link and timezone example * Revert "[env] exit if starting as root" This reverts commit f6e9090833a5180fe360a9ff54543c37c0ca3a58.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates logging.useUTC and replaces it with logging.timezone. The default timezone is still UTC. To use a local timezone set
logging.timezone: falseWe'll have a followup PR targeting 7.0 to remove the deprecation notice and default to a local timezone (and remove the optional 'false' schema).Explicit timezones help in situations such as docker containers where the system timezone isn't necessarily setup to be your timezone.
Closes #11038.