Revert "Point issue links to new choose page (#19042)" #21519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62badc5.
ppisljar
approved these changes
Aug 1, 2018
💚 Build Succeeded |
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revert #19042, due to a bug in GitHub. The new choose links will just show a 404 page not found in case you are not logged in, and won't forward you to login (as the old links do). So we should revert that for now, since this might end up bad UX and seem like a broken link for many users.
I reported that to GitHub using the contact form, if anyone know an additional channel to rise awareness for that issue, please feel free to report it there too.
Fixes #21453
Reopen #19213