Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add draft implementation of I18n engine (#19555) #21473

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau commented Jul 31, 2018

Backports the following commits to 6.x:

#20933

@LeanidShutau
Copy link
Contributor Author

Resolved conflicts in:
./src/ui/ui_render/ui_render_mixin.js
./package.json
./yarn.lock
./.eslintrc.js

@LeanidShutau LeanidShutau force-pushed the backport/6.x/pr-19555 branch from b8b0245 to f1e7a16 Compare July 31, 2018 13:58
@elastic elastic deleted a comment from elasticmachine Jul 31, 2018
@LeanidShutau LeanidShutau force-pushed the backport/6.x/pr-19555 branch from f1e7a16 to 730a7be Compare July 31, 2018 14:38
* Add draft implementation of I18n engine

* Add i18n loader

* kbn-i18n refactoring

* Fix react i18n context and update doc

* i18n engine refactoring

* Fix locales data loading and add more jsdoc comments

* Fix verify_translations task

* I18n tests refactoring

* Add build scripts to kbn-i18n package

* Fix some bugs

* Move uiI18nMixin into ui_i18n folder

* Add 'browser' field to kbn-i18n package.json

* Get rid of "showError" method

* Make i18n and i18nLoader a singleton object

* Add default locale as fallback if translation files were not registered

* Update yarn.lock

* kbn-i18n fix

* Add default formats

* Try to fix build

* Add more examples into kbn-i18n/README.md

* kbn-i18n fix

* Fix app_bootstrap tests

* Add links to issues in TODO comments
@LeanidShutau LeanidShutau force-pushed the backport/6.x/pr-19555 branch from 730a7be to 25c13f8 Compare July 31, 2018 15:06
@elastic elastic deleted a comment from elasticmachine Jul 31, 2018
@elastic elastic deleted a comment from elasticmachine Jul 31, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeanidShutau LeanidShutau requested a review from azasypkin August 1, 2018 09:56
@LeanidShutau LeanidShutau self-assigned this Aug 1, 2018
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeanidShutau LeanidShutau merged commit 1d0e438 into elastic:6.x Aug 1, 2018
@LeanidShutau LeanidShutau deleted the backport/6.x/pr-19555 branch August 1, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants