-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[security] Improve communication for ES/X-Pack being unavailable #21124
Conversation
Previously if Elasticsearch was unavailable in the Kibana default distribution, you would be prompted with a disabled login screen stating "Login is currently disabled. Administrators should consult the Kibana logs for more details". This was rather confusing for users who have a Basic license. This now provides the user with a screen providing only the required messaging. Additionally, if you were using Kibana with a Basic license with an OSS distribution of Elasticsearch, you would see the same disabled login screen as mentioned previously. This also separates the messaging there to provide clear details for the user to resolve the issue. Signed-off-by: Tyler Smalley <[email protected]>
cc @AlonaNadler and @clintongormley |
💚 Build Succeeded |
<p>Refer to the Kibana logs for more details.</p> | ||
</div> | ||
|
||
<div class="euiText loginErrorXpackUnavailable" ng-if="login.layout === 'error-xpack-unavailable'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thumbs up on static messages
</div> | ||
|
||
<div class="euiText loginErrorXpackUnavailable" ng-if="login.layout === 'error-xpack-unavailable'"> | ||
<p class="euiTitle euiTitle--medium euiTextColor euiTextColor--danger">Cannot connect to an Elasticsearch cluster running the OSS distribution from an instance of Kibana that has a Basic license or above.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, feel free to ignore: technically we are connected to the cluster and we may eventually be able to use it this way. maybe instead along the lines of kibana has x-pack and elasticsearch doesn't. please use matching distributions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also to distinguish from the other error message saying elasticsearch is offline (vs online but can't feature match)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debadair, thoughts here?
Talked with @tylersmalley over slack. For now I think this is clear enough to not be blocked by design. When @elastic/kibana-platform reactifies login in 6.5 I'll do a pass to make it look prettier with EUI. For now I'd just suggest a copy edit (@gchaps is out this week) so maybe @debadair can help. |
Spoke to Clint - adding copy to suggest refreshing the page to try again. |
There isn't really a way to upgrade, since there isn't a X-pack plugin anymore, so they will need a new install |
Signed-off-by: Tyler Smalley <[email protected]>
@AlonaNadler that wording is hard. Technically to move from the OSS distribution to the default would be the same method as upgrading and feature-wise is an "upgrade" in and of itself. Thoughts on what we could change it to? |
I pushed an update adding "refresh to try again" and updated the screenshots in the description. |
💚 Build Succeeded |
Signed-off-by: Tyler Smalley <[email protected]>
💚 Build Succeeded |
…stic#21124) Previously if Elasticsearch was unavailable in the Kibana default distribution, you would be prompted with a disabled login screen stating "Login is currently disabled. Administrators should consult the Kibana logs for more details". This was rather confusing for users who have a Basic license. This now provides the user with a screen providing only the required messaging. Additionally, if you were using Kibana with a Basic license with an OSS distribution of Elasticsearch, you would see the same disabled login screen as mentioned previously. This also separates the messaging there to provide clear details for the user to resolve the issue.
@tylersmalley I know it was merged, talking with @skearns64 we think we need a small modification to the OSS-Basic error message, as it might be misleading as is Any chance we can still change it to htis message: It appears you're running the oss-only distribution of Elasticsearch. To use the full set of free features in this distribution of Kibana, please update Elasticsearch to the default distribution |
I agree that is better - will get a PR up. |
) (#21183) Previously if Elasticsearch was unavailable in the Kibana default distribution, you would be prompted with a disabled login screen stating "Login is currently disabled. Administrators should consult the Kibana logs for more details". This was rather confusing for users who have a Basic license. This now provides the user with a screen providing only the required messaging. Additionally, if you were using Kibana with a Basic license with an OSS distribution of Elasticsearch, you would see the same disabled login screen as mentioned previously. This also separates the messaging there to provide clear details for the user to resolve the issue.
Previously if Elasticsearch was unavailable in the Kibana default distribution,
you would be prompted with a disabled login screen stating "Login is currently
disabled. Administrators should consult the Kibana logs for more details". This
was rather confusing for users who have a Basic license.
This now provides the user with a screen providing only the required
messaging.
Additionally, if you were using Kibana with a Basic license with an OSS
distribution of Elasticsearch, you would see the same disabled login
screen as mentioned previously.
This also separates the messaging there to provide clear details for the
user to resolve the issue.
Closes #20600
Closes #20177