Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Improve communication for ES/X-Pack being unavailable #21124

Merged
merged 4 commits into from
Jul 24, 2018

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Jul 24, 2018

Previously if Elasticsearch was unavailable in the Kibana default distribution,
you would be prompted with a disabled login screen stating "Login is currently
disabled. Administrators should consult the Kibana logs for more details". This
was rather confusing for users who have a Basic license.

This now provides the user with a screen providing only the required
messaging.

Additionally, if you were using Kibana with a Basic license with an OSS
distribution of Elasticsearch, you would see the same disabled login
screen as mentioned previously.

This also separates the messaging there to provide clear details for the
user to resolve the issue.

Closes #20600
Closes #20177

screenshot 2018-07-24 08 53 17

screenshot 2018-07-24 08 52 34

Previously if Elasticsearch was unavailable in the Kibana default distribution,
you would be prompted with a disabled login screen stating "Login is currently
disabled. Administrators should consult the Kibana logs for more details". This
was rather confusing for users who have a Basic license.

This now provides the user with a screen providing only the required
messaging.

Additionally, if you were using Kibana with a Basic license with an OSS
distribution of Elasticsearch, you would see the same disabled login
screen as mentioned previously.

This also separates the messaging there to provide clear details for the
user to resolve the issue.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley
Copy link
Contributor Author

cc @AlonaNadler and @clintongormley
@jbudz for review
@snide any thoughts on how to improve the styling here?

@tylersmalley tylersmalley added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Jul 24, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

<p>Refer to the Kibana logs for more details.</p>
</div>

<div class="euiText loginErrorXpackUnavailable" ng-if="login.layout === 'error-xpack-unavailable'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up on static messages

</div>

<div class="euiText loginErrorXpackUnavailable" ng-if="login.layout === 'error-xpack-unavailable'">
<p class="euiTitle euiTitle--medium euiTextColor euiTextColor--danger">Cannot connect to an Elasticsearch cluster running the OSS distribution from an instance of Kibana that has a Basic license or above.</p>
Copy link
Member

@jbudz jbudz Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, feel free to ignore: technically we are connected to the cluster and we may eventually be able to use it this way. maybe instead along the lines of kibana has x-pack and elasticsearch doesn't. please use matching distributions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also to distinguish from the other error message saying elasticsearch is offline (vs online but can't feature match)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debadair, thoughts here?

@snide
Copy link
Contributor

snide commented Jul 24, 2018

Talked with @tylersmalley over slack. For now I think this is clear enough to not be blocked by design. When @elastic/kibana-platform reactifies login in 6.5 I'll do a pass to make it look prettier with EUI.

For now I'd just suggest a copy edit (@gchaps is out this week) so maybe @debadair can help.

@tylersmalley
Copy link
Contributor Author

Spoke to Clint - adding copy to suggest refreshing the page to try again.

@AlonaNadler
Copy link

upgrade Elasticsearch to the defualt distribution

There isn't really a way to upgrade, since there isn't a X-pack plugin anymore, so they will need a new install

@tylersmalley
Copy link
Contributor Author

@AlonaNadler that wording is hard. Technically to move from the OSS distribution to the default would be the same method as upgrading and feature-wise is an "upgrade" in and of itself. Thoughts on what we could change it to?

@tylersmalley
Copy link
Contributor Author

I pushed an update adding "refresh to try again" and updated the screenshots in the description.

@jbudz
Copy link
Member

jbudz commented Jul 24, 2018

Tested both messages and cycling the cluster, LGTM. Noticed a small z-index with narrow width issue but otherwise lgtm.

image

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tylersmalley tylersmalley merged commit 716d6e2 into elastic:master Jul 24, 2018
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jul 25, 2018
…stic#21124)

Previously if Elasticsearch was unavailable in the Kibana default distribution,
you would be prompted with a disabled login screen stating "Login is currently
disabled. Administrators should consult the Kibana logs for more details". This
was rather confusing for users who have a Basic license.

This now provides the user with a screen providing only the required
messaging.

Additionally, if you were using Kibana with a Basic license with an OSS
distribution of Elasticsearch, you would see the same disabled login
screen as mentioned previously.

This also separates the messaging there to provide clear details for the
user to resolve the issue.
@AlonaNadler
Copy link

@tylersmalley I know it was merged, talking with @skearns64 we think we need a small modification to the OSS-Basic error message, as it might be misleading as is
image

Any chance we can still change it to htis message:

It appears you're running the oss-only distribution of Elasticsearch. To use the full set of free features in this distribution of Kibana, please update Elasticsearch to the default distribution

@tylersmalley
Copy link
Contributor Author

I agree that is better - will get a PR up.

tylersmalley added a commit that referenced this pull request Jul 25, 2018
) (#21183)

Previously if Elasticsearch was unavailable in the Kibana default distribution,
you would be prompted with a disabled login screen stating "Login is currently
disabled. Administrators should consult the Kibana logs for more details". This
was rather confusing for users who have a Basic license.

This now provides the user with a screen providing only the required
messaging.

Additionally, if you were using Kibana with a Basic license with an OSS
distribution of Elasticsearch, you would see the same disabled login
screen as mentioned previously.

This also separates the messaging there to provide clear details for the
user to resolve the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v6.4.0 v7.0.0
Projects
None yet
5 participants