[ML] Adding validation to the edit job flyout #21041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
jgowdyelastic
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💔 Build Failed |
jgowdyelastic
force-pushed
the
edit-job-validation
branch
from
8da0f90 to
d1969b9
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
jgowdyelastic
force-pushed
the
edit-job-validation
branch
from
d1969b9 to
0cea8af
Compare
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 23, 2018
* [ML] Adding validation to the edit job flyout * removing a bit of lodash * tiny code clean up * fixing validation check
jgowdyelastic
added a commit
that referenced
this pull request
Jul 23, 2018
|
Related to #20150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validation for group ids and model memory limit when editing a job.
Also splits out some functionality from a couple of the existing validation functions to allow me to just validate these items, rather than the whole job.
IMO client side job validation is in need of a rewrite to make it more modular and, if possible, use the same code as the server side validation.