[APM] Add apm_core plugin and query errors, spans, transactions from separate indices
#21022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
changed the title
apm_core and query errors, spans, transactions from separate indicesapm_core plugin and query errors, spans, transactions from separate indices
sorenlouv
commented
Jul 20, 2018
| export function apmSpecProvider(server) { | ||
| const config = server.config(); | ||
| const apmIndexPattern = getIndexPatternTitle(config); | ||
| const apmIndexPattern = config.get('apm_core.indexPattern'); |
There was a problem hiding this comment.
@nreese Any objections to this change?
sorenlouv
commented
Jul 20, 2018
src/core_plugins/apm_core/index.js
Outdated
| }).default(); | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
@epixa Created a new apm_core plugin with config vars. Looks ok?
There was a problem hiding this comment.
Seems fine to me at a glance!
|
Pinging @elastic/apm-ui |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
sorenlouv
force-pushed
the
apm-change-index-pattern
branch
from
9f61da1
to
13bb7f1
Compare
|
@sqren The tests are failing because Kibana CI is currently broken. Elasticsearch merged a change that broke some function tests. There is PR in place to fix CI |
|
@nreese That explains the (unusually) grumpy CI. Thanks for letting me know! |
💔 Build Failed |
💔 Build Failed |
sorenlouv
force-pushed
the
apm-change-index-pattern
branch
from
d06137b
to
91ae2a0
Compare
sorenlouv
force-pushed
the
apm-change-index-pattern
branch
from
91ae2a0
to
9a0578c
Compare
💚 Build Succeeded |
💚 Build Succeeded |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Jul 23, 2018
…m separate indices (elastic#21022) * [APM] Change index pattern * WIP: change how indicies are queried in APM * Create apm_core plugin * Update config keys from `xpack.apm` to `apm_core` * Revert tutorial formatting changes * Rename to apm_oss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of APM's config vars need to be available for other plugins (eg. Getting Started) even if APM UI is not available (like in Kibana OSS).
This PR adds a new
apm_coreplugin which contains the needed config vars, and is in OSS so should always be available for other plugins.APM in xpack and Getting Started plugin have been updated to use the config vars from
apm_coreinstead ofxpack.apm.Closes #20878
Closes #20978