Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tutorials to add data UI #21020

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jul 20, 2018

  • Golang
  • Logstash
  • Prometheus
  • Zookeeper

@ruflin ruflin added Feature:Add Data Add Data and sample data feature on Home Team:Beats labels Jul 20, 2018
@ruflin ruflin requested a review from tsg July 20, 2018 07:40
* Golang
* Logstash
* Prometheus
* Zookeeper
@ruflin ruflin force-pushed the add-metrics-tutorials branch from fb24780 to 494f06b Compare July 20, 2018 07:41
artifacts: {
application: {
label: 'Discover',
path: '/app/kibana#/discover'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a dashboard for Golang, f2dc7320-f519-11e6-a3c9-9d1f7c42b045. Shouldn't we link to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and tested. Seems to work.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruflin ruflin merged commit 47e784c into elastic:master Jul 20, 2018
ruflin added a commit to ruflin/kibana that referenced this pull request Jul 20, 2018
* Golang
* Logstash
* Prometheus
* Zookeeper
@ruflin ruflin deleted the add-metrics-tutorials branch July 20, 2018 13:02
ruflin added a commit that referenced this pull request Jul 20, 2018
* Golang
* Logstash
* Prometheus
* Zookeeper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Add Data Add Data and sample data feature on Home Team:Beats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants