[Monitoring] Use 0 as the default for shard count if the node is not found #21000

chrisronline · 2018-07-19T18:06:12Z

Fixes #20628

This PR changes the default for shardCount from null to 0.

@tsullivan Is this the right way to fix it? Or is the real problem that the coordinating node isn't returned in the getShardStats() call?

tsullivan · 2018-07-19T18:51:38Z

x-pack/plugins/monitoring/server/lib/elasticsearch/shards/get_shard_stats.js

@@ -58,6 +58,8 @@ export function getShardStats(req, esIndexPattern, cluster, { includeNodes = fal
    }
  };

+  console.log('CHRIS', JSON.stringify(params));
+


please remove :D

haha oh wow I'm ashamed that I left that in!

Eh, we've all done it. #21002 :D

tsullivan · 2018-07-19T18:55:04Z

x-pack/plugins/monitoring/server/lib/elasticsearch/nodes/get_nodes/map_nodes_info.js

@@ -35,7 +35,7 @@ export function mapNodesInfo(nodeHits, clusterStats, shardStats) {
        isOnline,
        nodeTypeLabel: nodeTypeLabel,
        nodeTypeClass: nodeTypeClass,
-        shardCount: get(shardStats, `nodes[${sourceNode.uuid}].shardCount`, null),
+        shardCount: get(shardStats, `nodes[${sourceNode.uuid}].shardCount`, 0),


👍 It looks good to fix the bug this way. It will help the UI make sense of the data and be able to sort it correctly when the table is sorted by number of shards.

elasticmachine · 2018-07-19T19:23:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-19T20:55:08Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-20T15:42:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2018-07-20T15:43:26Z

Looks like a flaky test:

RQXJOYpFJdU5qTaKoEttlJQNnEGQWslOwD8ozaepQAAAA==�[0mproc  [ftr]        │        tryForTime timeout: [POST http://localhost:9515/session/caa409f75c4023f0a3e9192e71e4fee6/element / {"using":"css selector","value":".visualization"}] no such element: Unable to locate element: {"method":"css selector","selector":".visualization"}

jenkins, test this

elasticmachine · 2018-07-20T17:13:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2018-07-23T14:28:46Z

jenkins, test this

elasticmachine · 2018-07-23T16:22:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

pickypg · 2018-07-23T16:38:14Z

You might want to try rebasing onto the latest master, @chrisronline.

pickypg

LGTM pending passing tests of course. I agree with Tim that this is a better solution than null.

elasticmachine · 2018-07-24T16:13:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tsullivan

LGTM!

tsullivan · 2018-07-24T16:30:49Z

I've seen an issue where this bug was reported in 5.5.3. I don't think this fix will be cleanly backportable that far. Feel free to backport this as far back as it will cleanly merge.

…found (elastic#21000) * Use 0 as the default for shard count if the node is not found * Remove debug * Updating snapshot tests * Update api integration test

chrisronline · 2018-07-24T17:00:33Z

@tsullivan It only goes back to 6.3 cleanly so will backport as far as there

…found (#21000) (#21166) * Use 0 as the default for shard count if the node is not found * Remove debug * Updating snapshot tests * Update api integration test

chrisronline · 2018-07-25T13:39:39Z

Backport:

6.x: 1e3d510
6.4: b96fed3
6.3: 9a74f94

…found (#21000) (#21165) * Use 0 as the default for shard count if the node is not found * Remove debug * Updating snapshot tests * Update api integration test

rashmivkulkarni · 2018-08-27T18:48:17Z

This didn't make it to 6.4.0 v.
Updating it to 6.4.1 .

cc @chrisronline @LeeDr

…found (elastic#21000) * Use 0 as the default for shard count if the node is not found * Remove debug * Updating snapshot tests * Update api integration test

…found (#21000) (#22428) * Use 0 as the default for shard count if the node is not found * Remove debug * Updating snapshot tests * Update api integration test

Use 0 as the default for shard count if the node is not found

ec34ff3

chrisronline added review v7.0.0 v6.4.0 Team:Monitoring Stack Monitoring team labels Jul 19, 2018

chrisronline self-assigned this Jul 19, 2018

chrisronline requested review from tsullivan and pickypg July 19, 2018 18:06

tsullivan requested changes Jul 19, 2018

View reviewed changes

tsullivan reviewed Jul 19, 2018

View reviewed changes

chrisronline added 2 commits July 19, 2018 15:26

Remove debug

f1b3a3e

Updating snapshot tests

a25666d

Update api integration test

7f144c0

pickypg approved these changes Jul 23, 2018

View reviewed changes

Merge remote-tracking branch 'elastic/master' into monitoring/fix/20628

16401b3

tsullivan approved these changes Jul 24, 2018

View reviewed changes

chrisronline merged commit 92dd341 into elastic:master Jul 24, 2018

chrisronline deleted the monitoring/fix/20628 branch July 24, 2018 16:56

chrisronline mentioned this pull request Jul 24, 2018

[6.x] [Monitoring] Use 0 as the default for shard count if the node is not found (#21000) #21165

Merged

chrisronline mentioned this pull request Jul 24, 2018

[6.3] [Monitoring] Use 0 as the default for shard count if the node is not found (#21000) #21166

Merged

chrisronline added the v6.3.3 label Jul 24, 2018

rashmivkulkarni added v6.4.1 and removed v6.4.0 labels Aug 27, 2018

chrisronline mentioned this pull request Aug 27, 2018

[6.4] [Monitoring] Use 0 as the default for shard count if the node is not found (#21000) #22428

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitoring] Use 0 as the default for shard count if the node is not found #21000

[Monitoring] Use 0 as the default for shard count if the node is not found #21000

chrisronline commented Jul 19, 2018

tsullivan Jul 19, 2018

chrisronline Jul 19, 2018

tsullivan Jul 19, 2018

tsullivan Jul 19, 2018

elasticmachine commented Jul 19, 2018

elasticmachine commented Jul 19, 2018

elasticmachine commented Jul 20, 2018

chrisronline commented Jul 20, 2018

elasticmachine commented Jul 20, 2018

chrisronline commented Jul 23, 2018

elasticmachine commented Jul 23, 2018

pickypg commented Jul 23, 2018

pickypg left a comment

elasticmachine commented Jul 24, 2018

tsullivan left a comment

tsullivan commented Jul 24, 2018

chrisronline commented Jul 24, 2018

chrisronline commented Jul 25, 2018 •

edited

Loading

rashmivkulkarni commented Aug 27, 2018

[Monitoring] Use 0 as the default for shard count if the node is not found #21000

[Monitoring] Use 0 as the default for shard count if the node is not found #21000

Conversation

chrisronline commented Jul 19, 2018

tsullivan Jul 19, 2018

Choose a reason for hiding this comment

chrisronline Jul 19, 2018

Choose a reason for hiding this comment

tsullivan Jul 19, 2018

Choose a reason for hiding this comment

tsullivan Jul 19, 2018

Choose a reason for hiding this comment

elasticmachine commented Jul 19, 2018

💔 Build Failed

elasticmachine commented Jul 19, 2018

💔 Build Failed

elasticmachine commented Jul 20, 2018

💔 Build Failed

chrisronline commented Jul 20, 2018

elasticmachine commented Jul 20, 2018

💔 Build Failed

chrisronline commented Jul 23, 2018

elasticmachine commented Jul 23, 2018

💔 Build Failed

pickypg commented Jul 23, 2018

pickypg left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 24, 2018

💚 Build Succeeded

tsullivan left a comment

Choose a reason for hiding this comment

tsullivan commented Jul 24, 2018

chrisronline commented Jul 24, 2018

chrisronline commented Jul 25, 2018 • edited Loading

rashmivkulkarni commented Aug 27, 2018

chrisronline commented Jul 25, 2018 •

edited

Loading