Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove beta label from tutorial overview page #20977

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Remove beta label from tutorial overview page #20977

merged 1 commit into from
Jul 19, 2018

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jul 19, 2018

Many modules are still in beta which made the beta label not very useful in the overview page. This disables the beta label for now.

The label is still shown when clicking on module.

@ruflin ruflin added Feature:Add Data Add Data and sample data feature on Home Team:Beats labels Jul 19, 2018
@ruflin ruflin requested a review from tsg July 19, 2018 12:05
@ruflin
Remove beta label from tutorial overview page
eb504c2 
Many modules are still in beta which made the beta label not very useful in the overview page. This disables the beta label for now.

The label is still shown when clicking on module.
@ruflin ruflin force-pushed the skip-beta-label branch from 26b4502 to eb504c2 Compare July 19, 2018 12:06
@ruflin ruflin requested a review from nreese July 19, 2018 12:06
tsg
tsg approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nreese
nreese approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI
code review

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor

nreese commented Jul 19, 2018

Looks like an unrelated test failure

src/cli/serve/integration_tests/reload_logging_config.test.js (29.241s)
12:21:24   ● Server logging configuration › should be reloadable via SIGHUP process signaling

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ruflin ruflin merged commit 469c005 into elastic:master Jul 19, 2018
@ruflin ruflin mentioned this pull request Jul 19, 2018
Merged
ruflin added a commit to ruflin/kibana that referenced this pull request Jul 19, 2018
@ruflin
Remove beta label from tutorial overview page (elastic#20977)
2e83f80 
Many modules are still in beta which made the beta label not very useful in the overview page. This disables the beta label for now.

The label is still shown when clicking on module.
@ruflin ruflin deleted the skip-beta-label branch July 20, 2018 08:12
ruflin added a commit that referenced this pull request Jul 20, 2018
@ruflin
Remove beta label from tutorial overview page (#20977) (#20988)
13f67f1 
Many modules are still in beta which made the beta label not very useful in the overview page. This disables the beta label for now.

The label is still shown when clicking on module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
Feature:Add Data Add Data and sample data feature on Home Team:Beats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruflin @elasticmachine @nreese @tsg