[tslint] enable no-default-export rule #20952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2018
Just like our ESLint rules, I think we should enforce named exports over default exports via TSLint. No changes to the code were necessary because of this linting rule because everyone is already following the pattern we established with ESLint, but TSLint wasn't actually verifying the pattern.
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2018
|
6.x/6.4: 17694da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like our ESLint rules, I think we should enforce named exports over default exports via TSLint. No changes to the code were necessary because of this linting rule because everyone is already following the pattern we established with ESLint, but TSLint wasn't actually verifying the pattern.