Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade xpack to [email protected] #20930

Merged
merged 10 commits into from
Jul 21, 2018
Merged

Upgrade xpack to [email protected] #20930

merged 10 commits into from
Jul 21, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 18, 2018 •
edited
Loading

Xpack needs [email protected] as well. Only Kibana's package.json was updated.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tylersmalley
Copy link
Contributor

dashboard app using legacy data dashboard panel controls panel edit controls are shown in edit mode

retest

@snide snide mentioned this pull request Jul 18, 2018
Merged
@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide snide changed the title Upgrade to [email protected] Upgrade to [email protected] Jul 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide snide changed the title Upgrade to [email protected] Upgrade to [email protected] Jul 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide snide changed the title Upgrade to [email protected] Upgrade to [email protected] Jul 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 18, 2018

jenkins, test this

1 similar comment
@snide
Copy link
Contributor Author

snide commented Jul 18, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 19, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide snide changed the title Upgrade to [email protected] Upgrade xpack to [email protected] Jul 19, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 19, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 20, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 20, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 20, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor

nreese commented Jul 20, 2018 •
edited
Loading

Looks like the new script does not compile. Needs to be changed to

        if (doc['machine.ram'].size() == 0) {
          return -1;
        } else {
          return doc['machine.ram'].value / (1024 * 1024 * 1024);
        }

I removed the / and there was a extra tick after "1024)"

Update, sorry, wrong PR, ignore comment

nreese
nreese approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review. Ran changes in chrome and checking out license management page and dashboard listing table

@cjcenizal
Copy link
Contributor

Retest

@nreese
Copy link
Contributor

nreese commented Jul 20, 2018

This is going to need to be synced with master to pick up the changes that fix the broken scripted fields

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 21, 2018

Sorry all, was on a plane this afternoon. Rebased. I'll get it in tomorrow assuming it passes tests (finally)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit 6ecc990 into elastic:master Jul 21, 2018
@snide snide deleted the eui/3.0.1 branch July 21, 2018 15:02
@snide snide mentioned this pull request Jul 21, 2018
Merged
snide added a commit to snide/kibana that referenced this pull request Jul 21, 2018
@snide
Upgrade xpack to [email protected] (elastic#20930)
3913d8e 
* upgrade to [email protected]

Conflicts:
	x-pack/yarn.lock
snide added a commit that referenced this pull request Jul 24, 2018
@snide
Upgrade xpack to [email protected] (#20930) (#21064)
bb7b22f 
* upgrade to [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snide @elasticmachine @tylersmalley @nreese @cjcenizal