Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only core in browser environment, loader in node env #20905

Merged
merged 3 commits into from
Jul 18, 2018
Merged

Use only core in browser environment, loader in node env #20905

merged 3 commits into from
Jul 18, 2018

Conversation

yankouskia
Copy link

Need to remove loader from browser env, as it uses node specific

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@yankouskia yankouskia added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n labels Jul 18, 2018
@maryia-lapata maryia-lapata mentioned this pull request Jul 18, 2018
Merged
azasypkin
azasypkin approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one optional nit.

packages/kbn-i18n/src/index.js Outdated
import * as loader from './loader';
import * as i18nCore from './core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional nit: looks like you can just revert change in this file :)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@yankouskia yankouskia merged commit 4445c58 into elastic:master Jul 18, 2018
@yankouskia yankouskia deleted the feature/i18n-package-core-env branch July 18, 2018 15:02
LeanidShutau pushed a commit to LeanidShutau/kibana that referenced this pull request Aug 2, 2018
@LeanidShutau
Use only core in browser environment, loader in node env (elastic#20905)
28e125e 
* use only core in browser environment and loader only in node env

* do not reexport node stuff from browser
@LeanidShutau LeanidShutau mentioned this pull request Aug 2, 2018
Merged
LeanidShutau added a commit that referenced this pull request Aug 2, 2018
@LeanidShutau
Use only core in browser environment, loader in node env (#20905) (#2…
78ef349 
…1587)

* use only core in browser environment and loader only in node env

* do not reexport node stuff from browser
@LeanidShutau
Copy link
Contributor

6.x/6.5: 78ef349

@LeanidShutau LeanidShutau removed their request for review August 16, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backported Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yankouskia @elasticmachine @LeanidShutau @azasypkin @maryia-lapata